Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubscribe even when there are no listeners #30

Merged
merged 1 commit into from
Feb 1, 2015

Conversation

kichik
Copy link
Contributor

@kichik kichik commented Jan 31, 2015

Listeners might be added after subscription and a disconnection can happen in between the two
Listeners may also be added and removed dynamically causing subscriptions to be lost on reconnection

Listeners might be added after subscription and a disconnection can happen in between the two
Listeners may also be added and removed dynamically causing subscriptions to be lost on reconnection
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 96.27% when pulling d386367 on kichik:resubscribe_with_no_listeners into 1fba063 on mp911de:master.

@mp911de mp911de added the type: bug A general bug label Feb 1, 2015
@mp911de
Copy link
Collaborator

mp911de commented Feb 1, 2015

Thanks for the fix.

mp911de added a commit that referenced this pull request Feb 1, 2015
Resubscribe even when there are no listeners
@mp911de mp911de merged commit 4c86fca into redis:master Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants