Skip to content

Commit

Permalink
test: improve version-specific test coverage
Browse files Browse the repository at this point in the history
- Add `testWithClientIfVersionWithinRange` method to run tests for specific Redis versions
- Refactor TestUtils to handle version comparisons more accurately
- Update test utilities across Redis modules to run tests against multiple versions, and not against latest only
  • Loading branch information
bobymicroby committed Feb 25, 2025
1 parent a216755 commit cd214f5
Show file tree
Hide file tree
Showing 15 changed files with 485 additions and 147 deletions.
4 changes: 2 additions & 2 deletions packages/bloom/lib/test-utils.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import TestUtils from '@redis/test-utils';
import RedisBloomModules from '.';

export default new TestUtils({
export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redisbloom-version',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.0-M04-pre'
});

Expand Down
2 changes: 1 addition & 1 deletion packages/client/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { CredentialsProvider } from './authx';
import { Command } from './RESP/types';
import { BasicCommandParser } from './client/parser';

const utils = new TestUtils({
const utils = TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.0-M04-pre'
Expand Down
2 changes: 1 addition & 1 deletion packages/entraid/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { IdentityProvider, StreamingCredentialsProvider, TokenManager, TokenResp
import TestUtils from '@redis/test-utils';
import { EntraidCredentialsProvider } from './entraid-credentials-provider';

export const testUtils = new TestUtils({
export const testUtils = TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.0-M04-pre'
Expand Down
4 changes: 2 additions & 2 deletions packages/graph/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import TestUtils from '@redis/test-utils';
import RedisGraph from '.';


export default new TestUtils({
export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redisgraph-version',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.0-M04-pre'
});

Expand Down
4 changes: 2 additions & 2 deletions packages/json/lib/test-utils.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import TestUtils from '@redis/test-utils';
import RedisJSON from '.';

export default new TestUtils({
export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redisgraph-version',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.0-M04-pre'
});

Expand Down
2 changes: 1 addition & 1 deletion packages/search/lib/commands/CONFIG_SET.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe('FT.CONFIG SET', () => {
);
}, GLOBAL.SERVERS.OPEN);

testUtils.testWithClient('setSearchConfigGloballyTest', async client => {
testUtils.testWithClientIfVersionWithinRange([[8], 'LATEST'], 'setSearchConfigGloballyTest', async client => {

const normalizeObject = obj => JSON.parse(JSON.stringify(obj));
assert.equal(await client.configSet('search-default-dialect', '3'),
Expand Down
Loading

0 comments on commit cd214f5

Please sign in to comment.