Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fractfact_opt for Python3 #10

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Fix fractfact_opt for Python3 #10

merged 4 commits into from
Jun 12, 2024

Conversation

relf
Copy link
Owner

@relf relf commented Jun 12, 2024

Resolves #9

@relf
Copy link
Owner Author

relf commented Jun 12, 2024

@jvailius, your example fractfac_opt(4, 1) returns now ('a b c abc', ['a = bcd', 'b = acd', 'c = abd', 'd = abc', 'ab = cd', 'ac = bd', 'ad = bc', 'abcd'], array([0., 0., 3., 4., 0., 0., 0., 0., 0., 0.]))
Does it make sense to you? I can add an assertion on the return value but I am not familiar with the function so just to check it is ok for you.

@jvailius
Copy link

Does it make sense to you?

I have not the faintest idea to be honest :D I am relatively new to DOE but this looks like an interesting function and I will further explore it. The result is identical what I get with my fix. Thank you.

@relf relf merged commit 5150175 into master Jun 12, 2024
4 checks passed
@relf relf deleted the fix-issue-9 branch June 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in fracfact_opt
2 participants