Add context awareness #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the Add call to be interrupted by context cancellation.
|
Hello Henry, thanks for the pull-request! I'll check this out soon. |
remeh
requested changes
Aug 17, 2018
There was a problem hiding this comment.
Hi Henry,
I think it would be better to do it another way: simply by adding a method called AddWithContext(ctx context.Context).
The Go documentation mentions that it is not a good practice to store a context inside a struct (see https://golang.org/pkg/context/), it would also be more idiomatic as many packages of the standard library have chosen this solution. On top of that, it would avoid having to return an error/nil in the method Add().
sizedwaitgroup.go
Outdated
| // | ||
| // See sync.WaitGroup documentation for more information. | ||
| func (s *SizedWaitGroup) Add() { | ||
| s.current <- struct{}{} | ||
| func (s *SizedWaitGroup) Add() error { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Hi @hstern , that looks perfect! Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the Add call to be interrupted by context cancellation.