feat(examples/firebase): deploy to Cloud Functions for Firebase #3398
Conversation
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2" | ||
| "react-dom": "^17.0.2", | ||
| "remix-google-cloud-functions": "0.0.1" |
There was a problem hiding this comment.
I've created and published this adapter separately, I can either:
- manage this myself in its own repository
- contribute it back as
@remix-run/google-cloud-functions
I've opened up a separate PR for this at #3397
There was a problem hiding this comment.
Let's merge #3397 first before continuing with this.
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2" | ||
| "react-dom": "^17.0.2", | ||
| "remix-google-cloud-functions": "0.0.1" |
There was a problem hiding this comment.
Let's merge #3397 first before continuing with this.
|
Now that |
|
@penx If you want, you can do that in another PR |
|
Can I use this right now? |
#3397 was closed in favour of #2266 which has stalled for 2 months due to new adapters not being high on the priority list. I think it would be worth revisiting this example without waiting for #2266 as it is something that comes up by users e.g. in Discord. I would suggest either:
Any suggestions/preference @MichaelDeBoey @kentcdodds? |
@imadbz sorry for the late reply, yes remix-google-cloud-functions (previously remix-firebase) should be good to use now as per the example code in this PR |
MichaelDeBoey
changed the title
|
@penx Please rebase your PR onto latest |
MichaelDeBoey
added
the
needs-response
There was a problem hiding this comment.
I'm not 100% if we want to merge this tbh, as we'll most likely create an official template once #2266 is merged 🤔
Co-authored-by: Michaël De Boey <[email protected]>
penx
force-pushed
the
firebase-functions
branch
from
7acb54e to
b2b4cb4
Compare
|
Once #2266 is merged and there is an official template, wouldn't it still make sense for the example to be using the adapter too so that it's a "one-stop example for all things firebase"? |
|
GitHub for some reason removed @machour automatically when I re-requested review from @MichaelDeBoey. I'm not sure why it shows me as removing @machour as I don't have access to do that 😄 |
MichaelDeBoey
removed
the
needs-response
|
FYI we are migrating all examples over to https://github.com/remix-run/examples. If you are still interested in including this example, feel free to open a new PR there at your convenience 🙂 |
|
Reopened as remix-run/examples#5 |
Ported from remix-run/remix#3398 fix yarn lock on main
Ported from remix-run/remix#3398 fix yarn lock on main
An exact version is needed as Firebase uses this to determine which version of node to use for the functions when you run `firebase deploy`
Node 14 is a mismatch to root .nvmrc which is set to 16
This will result in errors from both yarn and npm install.
```
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: undefined,
npm WARN EBADENGINE required: { node: '14' },
npm WARN EBADENGINE current: { node: 'v16.19.0', npm: '8.19.3' }
npm WARN EBADENGINE }
```
This could be skipped using `yarn --ignore-engines`, but I don't think that's a great experience for an example project.
Previous discussion.
remix-run/remix#3398 (comment)
Deploy to firebase functions and hosting
Closes: Discussion at #1811 (comment)
Testing Strategy: