-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-dev): Add loaders config for 3d models #4457
feat(remix-dev): Add loaders config for 3d models #4457
Conversation
🦋 Changeset detectedLatest commit: 2254eef The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR 🙏
We also need you to generate the changeset, see the comment added by the bot on the PR.
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@machour Have made the appropriate changes. |
@machour Can you please review the code and approve it it is okay, as we need these loaders for our project. |
@ikarus-akhil there seem to be a conflict with the changeset file, other than that looks good to me. 👌🏼 In the mean time, if you can't wait any longer, I suggest using https://www.npmjs.com/package/patch-package to apply these changes on your project. You might also be interested in this proposal #4549 that will turn into an RFC soon and hopefully make it to Remix. |
@machour I have resolved the conflict, can you please merge this code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong with the changesets, it seems you edited an old one and included it again as new?
@machour Sorry for the delay and all the trouble, was having problem with the changeset but now I think it should be good. |
Looks like this was shipped in 1.11, resolved in #5030. I'm going to close this but I'll add @ikarus-akhil to our contributors list since we dropped the ball on reviewing in a timely manner. Sorry about that! |
Adds support for importing
.glb
,.gltf
and.hdr
files.Closes: #4430
Testing Strategy:
I was able to import
.glb
and.hdr
files and use them in google model viewer linked using its CDN.