ci: add typechecking for deno #4715

ascorbic · 2022-11-30T13:19:43Z

Currently no typechecking is performed on the remix-deno package, because tsc cannot handle .ts file extension imports. This PR adds support for typechecking using the deno check command.

Closes: #

Docs
Tests

Testing Strategy:

Run yarn build --deno

changeset-bot · 2022-11-30T13:19:45Z

🦋 Changeset detected

Latest commit: c63f5d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/deno	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/dev	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ascorbic · 2022-11-30T13:31:48Z

.vscode/deno_resolve_npm_imports.json

+  "comment": [
+    "Resolve NPM imports for `packages/remix-deno`.",
+    "This import map is used solely for the denoland.vscode-deno extension.",
+    "Remix does not support import maps.",
+    "Dependency management is done through `npm` and `node_modules/` instead.",
+    "Deno-only dependencies may be imported via URL imports (without using import maps)."
+  ],


Moved it here because otherwise the typechecker gives lots of scary-looking warnings. Now it just gives one, less scary warning.

ascorbic · 2022-11-30T13:32:18Z

packages/remix-deno/server.ts

-export function createRequestHandler<Context = unknown>({
+export function createRequestHandler<
+  Context extends AppLoadContext | undefined = undefined
+>({


This was a type error that the typecheck uncovered

.vscode/deno_resolve_npm_imports.json

.github/workflows/reusable-test.yml

mcansh

thanks @ascorbic 🙌 - looks like deno check will only run when passing --deno but i don't think we're actually doing that anywhere in CI?

ascorbic · 2022-11-30T19:09:57Z

@mcansh it also runs if process.env.CI is true, so should run every time

mcansh · 2022-11-30T19:10:44Z

@mcansh it also runs if process.env.CI is true, so should run every time

ope you're right 🤦‍♂️ 👍

x-ref: #4715

when adding deno typechecking (#4715), nightly now refers to the version we just calculated which hasnt been published when trying to build and typecheck Signed-off-by: Logan McAnsh <[email protected]>

* ci(nightly): move git operations after build when adding deno typechecking (#4715), nightly now refers to the version we just calculated which hasnt been published when trying to build and typecheck Signed-off-by: Logan McAnsh <[email protected]> * ci: update tmp branch name Signed-off-by: Logan McAnsh <[email protected]> Signed-off-by: Logan McAnsh <[email protected]>

* ci(nightly): move git operations after build when adding deno typechecking (#4715), nightly now refers to the version we just calculated which hasnt been published when trying to build and typecheck Signed-off-by: Logan McAnsh <[email protected]> * ci: update tmp branch name Signed-off-by: Logan McAnsh <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> (cherry picked from commit c9413eb)

This partially reverts commit c6415bb.

* ci(nightly): move git operations after build when adding deno typechecking (#4715), nightly now refers to the version we just calculated which hasnt been published when trying to build and typecheck Signed-off-by: Logan McAnsh <[email protected]> * ci: update tmp branch name Signed-off-by: Logan McAnsh <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> (cherry picked from commit c9413eb)

* fix(remix-dev): convert `config.appDirectory` to relative unix path (#4709) * fix(remix-dev): convert appDirectory to unix style for fast-glob Signed-off-by: Logan McAnsh <[email protected]> * chore: relative path Signed-off-by: Logan McAnsh <[email protected]> * chore: add test Signed-off-by: Logan McAnsh <[email protected]> * fix test Signed-off-by: Logan McAnsh <[email protected]> * fix: typo Signed-off-by: Logan McAnsh <[email protected]> * chore: update test Signed-off-by: Logan McAnsh <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> * chore: add changeset for #4709 (#4718) * ci: add typechecking for deno (#4715) * ci: add typechecking for deno * ci: install deno for integration tests * chore: format * chore: format * fix: Firefox LiveReload (#4725) Firefox infinitely reloads the page as long as `<LiveReload>` is rendering. Closes #4692 * fix(remix-dev): allow defining multiple routes for the same route module file (#3970) * Allow multiple routes for same route module * Update packages/remix-dev/config/routes.ts Co-authored-by: Andrew Leedham <[email protected]> * Update routes.ts - Better name for automated ID variable; - Small adjust in `id` option comment; * - Removing redundant IF * Update routes.ts Revert complex custom ID in routes * Non unique custom routes ID error and test * Update assets.ts Trying to solve a conflict * Revert "Update assets.ts" This reverts commit 2064c57. * Error on collisions with non-custom routeIds * Create big-spoons-grab.md Co-authored-by: Andrew Leedham <[email protected]> Co-authored-by: Matt Brophy <[email protected]> * feat: Allow pass-through script props in `ScrollRestoration` (#2879) * ci(nightly): add deno for typechecking deno files (#4738) * ci: fix race condition writing globals.d.ts shim (#4717) Co-authored-by: Chance Strickland <[email protected]> * chore: bump @playwright/test to latest (#4749) Signed-off-by: Logan McAnsh <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> * Fix 4199: TypedResponse allows incompatible types (#4734) * Fixes #4199: Do not allow assignment of incompatible TypedResponses * Add myself to contributors.yml * Create light-sheep-give.md * slight changeset tweak * additional changeset tweaks Co-authored-by: Pedro Cattori <[email protected]> * chore: format * test: add transition integration tests (#4739) test: useTransition to wait for states This approach could probably be applied across other flakey tests and could also be documented as a good approach of if there is user-feedback for a specific action when running integration tests. * feat: testing helpers (#4539) Co-authored-by: James Restall <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> * chore: format * chore(remix-testing): update dependencies (#4756) * fix(remix-testing): fix deps (#4757) * Fix deps for new remix-testing package * fix lint * Remove ENABLE_REMIX_ROUTER flags (#4732) * chore: add `@remix-run/testing` to changesets (#4781) * chore: add `@remix-run/testing` to changesets Signed-off-by: Logan McAnsh <[email protected]> * chore: update `ADDING_A_PACKAGE.md` Signed-off-by: Logan McAnsh <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> * refactor(remix-react): upgrade Remix to `[email protected]` (non-data-router) and drop `history` (#4731) * Bump remix to [email protected] (#4668) Co-authored-by: Mehdi Achour <[email protected]> * Bump remix to RR 6.4.4 and drop history dependency (#4702) Co-authored-by: Mehdi Achour <[email protected]> * ci(nightly): move git operations after build (#4797) * ci(nightly): move git operations after build when adding deno typechecking (#4715), nightly now refers to the version we just calculated which hasnt been published when trying to build and typecheck Signed-off-by: Logan McAnsh <[email protected]> * ci: update tmp branch name Signed-off-by: Logan McAnsh <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> * perf(remix-dev): Optimize `parentRouteId` lookup in `defineConventionalRoutes` (#4538) * Use object for parentRouteId lookup * Sign CLA * Move parentRouteId logic to a separate function * Update test fixture path * chore: format * chore(dev): add changeset for PR #4538 (#4800) * chore: format * refactor(remix-react): use `react-router-dom` import instead of `react-router` (#3325) * chore: manually bump remix-testing version due to not being on main just yet Signed-off-by: Logan McAnsh <[email protected]> * fixup! chore: manually bump remix-testing version due to not being on main just yet * fixup! chore: manually bump remix-testing version due to not being on main just yet Signed-off-by: Logan McAnsh <[email protected]> * chore: unify error usage (#4696) * chore: format * Add fetcher state/type tests (#4803) * chore(deps): bump esbuild to latest (#4754) * chore: add invariant instead of using `!` Signed-off-by: Logan McAnsh <[email protected]> * chore(deps): bump esbuild to latest Signed-off-by: Logan McAnsh <[email protected]> * Create fresh-shrimps-join.md Signed-off-by: Logan McAnsh <[email protected]> Co-authored-by: Pedro Cattori <[email protected]> * test(integration): close server synchronously (#4785) * chore: normalize afterAll Signed-off-by: Logan McAnsh <[email protected]> * test: close server synchronously Signed-off-by: Logan McAnsh <[email protected]> * chore: appFixture.close isnt async anymore Signed-off-by: Logan McAnsh <[email protected]> * Update integration/helpers/create-fixture.ts Co-authored-by: Pedro Cattori <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> Co-authored-by: Pedro Cattori <[email protected]> * feat: remix optional segments (#4706) * feat: transform optional routes from remix to react router * Add to contributors * Add changeset * fix(optional-segments): fix escaping of parenthesis * small function fix * Update packages/remix-dev/__tests__/routesConvention-test.ts Co-authored-by: Pedro Cattori <[email protected]> Co-authored-by: Pedro Cattori <[email protected]> * chore: format * chore: edit the optional segments changeset (#4815) to make it clear that Remix won't support optional segments until integrated with React Router 6.5 * chore: format * docs: rearrange docs, give everything its own page (#4821) * chore: format * fix: wrong parentheses in the optional segments changeset (#4825) * fix: wrong parentheses in the optional segments changeset * add: akamfoad to the contributers * ci(nightly): add workflow_call for testing purposes Signed-off-by: Logan McAnsh <[email protected]> * Revert "ci(nightly): add workflow_call for testing purposes" This reverts commit f3fa77e. * chore(scripts): Use relaxed peer dependencies to avoid triggering major version bumps (#4736) - Add script to bump peer deps with changesets version Co-authored-by: Mateusz Burzyński <[email protected]> * Add integration tests for request structures (#4829) * fix(remix-dev): resolve asset entry full path to support mono-repo import of styles (#4855) * chore: have eslint report unused eslint comments (#4863) * chore: have eslint report unused eslint comments Signed-off-by: Logan McAnsh <[email protected]> * chore: remove additional comment Signed-off-by: Logan McAnsh <[email protected]> * perf(remix-architect,remix-netlify): improve performance of `isBinaryType` (#4761) Co-authored-by: Logan McAnsh <[email protected]> Co-authored-by: Pannatier Guillaume <[email protected]> * chore: format * chore(remix-testing): remove internal installGlobals (#4755) * chore: remove internal installGlobals Signed-off-by: Logan McAnsh <[email protected]> * chore: add README Signed-off-by: Logan McAnsh <[email protected]> * Create quick-cats-fix.md * Update .changeset/quick-cats-fix.md Co-authored-by: Michaël De Boey <[email protected]> * chore(deps): remove jsdom and happydom from devDependencies Signed-off-by: Logan McAnsh <[email protected]> Signed-off-by: Logan McAnsh <[email protected]> Co-authored-by: Michaël De Boey <[email protected]> * fix(dev): build js modules for ts->js conversion The TS->JS migration was removed from the CLI codemod options, but still used for TS->JS conversion when creating a new Remix project from the CLI. The TS modules responsible for the TS->JS conversion were incorrectly removed from the Rollup build, resulting in the corresponding built JS modules being absent. That caused the CLI to error when trying to perform TS->JS conversion. This changes reintroduces the wiring to build the modules responsible for the TS->JS conversion. Fixes #4854 Signed-off-by: Logan McAnsh <[email protected]> Co-authored-by: Logan McAnsh <[email protected]> Co-authored-by: Matt Kane <[email protected]> Co-authored-by: Remix Run Bot <[email protected]> Co-authored-by: Chance Strickland <[email protected]> Co-authored-by: Ryan Florence <[email protected]> Co-authored-by: Lucas Ferreira <[email protected]> Co-authored-by: Andrew Leedham <[email protected]> Co-authored-by: Matt Brophy <[email protected]> Co-authored-by: dabdine <[email protected]> Co-authored-by: Jacob Ebey <[email protected]> Co-authored-by: James Restall <[email protected]> Co-authored-by: Michaël De Boey <[email protected]> Co-authored-by: Mehdi Achour <[email protected]> Co-authored-by: Dylan Markow <[email protected]> Co-authored-by: Daniel Rios <[email protected]> Co-authored-by: Akam Foad <[email protected]> Co-authored-by: Mateusz Burzyński <[email protected]> Co-authored-by: Guillaume Pannatier <[email protected]> Co-authored-by: Pannatier Guillaume <[email protected]>

remix-cla-bot bot added the CLA Signed label Nov 30, 2022

ascorbic force-pushed the mk/deno-typecheck branch from cccb30e to 5edbbbd Compare November 30, 2022 13:23

ascorbic marked this pull request as draft November 30, 2022 13:25

ascorbic force-pushed the mk/deno-typecheck branch from 5edbbbd to 66f6d3e Compare November 30, 2022 13:27

ascorbic marked this pull request as ready for review November 30, 2022 13:27

ascorbic mentioned this pull request Nov 30, 2022

feat: add @remix-run/netlify-edge package + update Netlify template #3104

Closed

2 tasks

ascorbic commented Nov 30, 2022

View reviewed changes

machour added feat:typescript feat:deno Issues related to Deno support labels Nov 30, 2022

machour requested a review from pcattori November 30, 2022 13:33

machour added the runtime:deno label Nov 30, 2022

ascorbic force-pushed the mk/deno-typecheck branch from 66f6d3e to 5178317 Compare November 30, 2022 13:35

ci: add typechecking for deno

a3b5315

ascorbic force-pushed the mk/deno-typecheck branch from 5178317 to a3b5315 Compare November 30, 2022 13:38

ci: install deno for integration tests

c63f5d8

MichaelDeBoey requested review from mcansh and chaance November 30, 2022 15:59

MichaelDeBoey approved these changes Nov 30, 2022

View reviewed changes

.vscode/deno_resolve_npm_imports.json Show resolved Hide resolved

.github/workflows/reusable-test.yml Show resolved Hide resolved

mcansh approved these changes Nov 30, 2022

View reviewed changes

pcattori approved these changes Nov 30, 2022

View reviewed changes

pcattori merged commit c6415bb into remix-run:dev Nov 30, 2022

ascorbic deleted the mk/deno-typecheck branch December 1, 2022 10:31

mcansh added a commit that referenced this pull request Dec 1, 2022

ci(nightly): add deno for typechecking deno files

633858f

x-ref: #4715

This was referenced Dec 1, 2022

ci(nightly): add deno for typechecking deno files #4738

Merged

ci(nightly): add deno for typechecking deno files #4763

Merged

mcansh mentioned this pull request Dec 7, 2022

ci(nightly): move git operations after build #4797

Merged

2 tasks

mcansh mentioned this pull request Dec 9, 2022

ci(nightly): move git operations after build #4814

Merged

2 tasks

This was referenced Dec 12, 2022

ci(experimental): add deno for typechecking deno files #4847

Closed

ci(experimental): add deno for typechecking deno files #4848

Closed

mcansh added a commit that referenced this pull request Dec 13, 2022

Revert "ci: add typechecking for deno (#4715)"

f96b9d1

This partially reverts commit c6415bb.

mcansh mentioned this pull request Dec 13, 2022

Revert "ci: add typechecking for deno (#4715)" #4856

Merged

2 tasks

This was referenced Dec 13, 2022

chore: Update version for release (pre) #4858

Closed

chore: Update version for release (pre) #4869

Closed

chore: Update version for release (pre) #4871

Merged

remix-run-bot mentioned this pull request Dec 16, 2022

chore: Update version for release #4893

Merged

mcansh added a commit that referenced this pull request Dec 16, 2022

Revert "ci: add typechecking for deno (#4715)" (#4856)

d017db3

chaance pushed a commit that referenced this pull request Dec 16, 2022

Revert "ci: add typechecking for deno (#4715)" (#4856)

7086b49

staylor pushed a commit to staylor/remix that referenced this pull request Jan 9, 2023

Revert "ci: add typechecking for deno (remix-run#4715)" (remix-run#4856)

7674449

mcansh mentioned this pull request Jan 10, 2023

chore: Update version for release (pre) #5050

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add typechecking for deno #4715

ci: add typechecking for deno #4715

ascorbic commented Nov 30, 2022

changeset-bot bot commented Nov 30, 2022 •

edited

Loading

ascorbic Nov 30, 2022 •

edited

Loading

ascorbic Nov 30, 2022

mcansh left a comment •

edited

Loading

ascorbic commented Nov 30, 2022

mcansh commented Nov 30, 2022

ci: add typechecking for deno #4715

ci: add typechecking for deno #4715

Conversation

ascorbic commented Nov 30, 2022

changeset-bot bot commented Nov 30, 2022 • edited Loading

🦋 Changeset detected

ascorbic Nov 30, 2022 • edited Loading

Choose a reason for hiding this comment

ascorbic Nov 30, 2022

Choose a reason for hiding this comment

mcansh left a comment • edited Loading

Choose a reason for hiding this comment

ascorbic commented Nov 30, 2022

mcansh commented Nov 30, 2022

changeset-bot bot commented Nov 30, 2022 •

edited

Loading

ascorbic Nov 30, 2022 •

edited

Loading

mcansh left a comment •

edited

Loading