[CN-Test-Gen] Rewrite ownership and allocation checking #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now separated from the CN-Exec allocator
ZippeyKeys12
added a commit
to ZippeyKeys12/cerberus
that referenced
this pull request
Nov 18, 2024
Already generalized in the runtime in rems-project#674
ZippeyKeys12
added a commit
that referenced
this pull request
Nov 19, 2024
Already generalized in the runtime in #674
vzaliva
pushed a commit
to vzaliva/cerberus
that referenced
this pull request
Dec 4, 2024
…#674) No longer connected to CN-Exec ownership tracking or the CN-Exec allocator
vzaliva
pushed a commit
to vzaliva/cerberus
that referenced
this pull request
Dec 4, 2024
Already generalized in the runtime in rems-project#674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a slightly unsound approach that piggy-backed off the executable spec work. Now there's a fully sound version that provides checkpoints, without sacrificing too much speed.
This means not using the CN-Exec allocator. With the CN allocator's only use during generation being for the values constructed, we can implement a similar checkpoint system in order to no longer leak memory when backtracking.