Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] handler decomposition #125

Merged
merged 4 commits into from
Nov 28, 2024
Merged

[tests] handler decomposition #125

merged 4 commits into from
Nov 28, 2024

Conversation

blast-hardcheese
Copy link
Contributor

Why

Striking a balance between test handler reuse and colocating the handler specifiers with the tests that use them.

What changed

  • Decomposing monolithic server handler specifiers into directly DI-ing reusable components
  • For tests that need bespoke handlers, defining those alongside the methods that use them.

Test plan

CI

@blast-hardcheese blast-hardcheese marked this pull request as ready for review November 28, 2024 19:41
@blast-hardcheese blast-hardcheese requested a review from a team as a code owner November 28, 2024 19:41
@blast-hardcheese blast-hardcheese requested review from ryantm and cbrewster and removed request for a team November 28, 2024 19:41
@blast-hardcheese
Copy link
Contributor Author

@cbrewster Following up on an earlier PR comment. This brings handler invocation closer to the tests that use them.

cbrewster
cbrewster approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@cbrewster cbrewster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like it

@blast-hardcheese blast-hardcheese merged commit 502278f into main Nov 28, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/handler-decomposition branch November 28, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrewster cbrewster cbrewster approved these changes

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner automatically assigned from replit/pid2-reviewers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blast-hardcheese @cbrewster