Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused assertion #121

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Remove unused assertion #121

merged 2 commits into from
Jan 16, 2025

Conversation

Tomperez98
Copy link
Collaborator

@Tomperez98 Tomperez98 commented Jan 16, 2025

This assertion assumed that a callback is return even if we duplicate on the durable promise. But this is not true, the API only returns a callback on the event it is created.

This assertion is not an invariant

@Tomperez98 Tomperez98 merged commit 34bbfad into main Jan 16, 2025
4 checks passed
@Tomperez98 Tomperez98 deleted the tomas/remove-unused-assertion branch January 16, 2025 22:20
@Tomperez98 Tomperez98 linked an issue Jan 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got error while testing demo
1 participant