Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If no task + remote server. Do nothing #126

Merged
merged 2 commits into from
Jan 20, 2025
Merged

If no task + remote server. Do nothing #126

merged 2 commits into from
Jan 20, 2025

Conversation

Tomperez98
Copy link
Collaborator

No description provided.

@Tomperez98 Tomperez98 linked an issue Jan 20, 2025 that may be closed by this pull request
Hit assert when restarting a node with a pending promise #123
Closed
@Tomperez98 Tomperez98 requested review from dfarr and avillega January 20, 2025 22:40
avillega
avillega approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@avillega avillega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dfarr
dfarr approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Tomperez98 Tomperez98 merged commit 5f0e5ef into main Jan 20, 2025
4 checks passed
@Tomperez98 Tomperez98 deleted the tomas/no-progress-without-task branch January 20, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfarr dfarr dfarr approved these changes

@avillega avillega avillega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hit assert when restarting a node with a pending promise
3 participants
@Tomperez98 @dfarr @avillega