Return StatusOk if task is already completed

resonatehq · Mar 6, 2025 · 3a96170 · 3a96170
1 parent 5d42a86
commit 3a96170
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/app/coroutines/completeTask.go b/internal/app/coroutines/completeTask.go
@@ -47,7 +47,7 @@ func CompleteTask(c gocoro.Coroutine[*t_aio.Submission, *t_aio.Completion, any],
 		}
 
 		if t.State == task.Completed || t.State == task.Timedout {
-			status = t_api.StatusTaskAlreadyCompleted
+			status = t_api.StatusOK
 		} else if t.State == task.Init || t.State == task.Enqueued {
 			status = t_api.StatusTaskInvalidState
 		} else if t.Counter != r.CompleteTask.Counter {

diff --git a/test/dst/validator.go b/test/dst/validator.go
@@ -681,7 +681,7 @@ func (v *Validator) ValidateCompleteTask(model *Model, reqTime int64, resTime in
 		model = model.Copy()
 		model.tasks.set(req.CompleteTask.Id, res.CompleteTask.Task)
 		return model, nil
-	case t_api.StatusTaskAlreadyCompleted:
+	case t_api.StatusOK:
 		if t == nil {
 			return model, fmt.Errorf("task '%s' does not exist", req.CompleteTask.Id)
 		}
@@ -700,7 +700,7 @@ func (v *Validator) ValidateCompleteTask(model *Model, reqTime int64, resTime in
 					IdempotencyKeyForComplete: p.IdempotencyKeyForComplete,
 					Tags:                      p.Tags,
 					CreatedOn:                 p.CreatedOn,
-					CompletedOn:               &reqTime,
+					CompletedOn:               util.ToPointer(p.Timeout),
 					SortId:                    p.SortId,
 				}
 				model.promises.set(p.Id, &newP)