Skip to content

Commit

Permalink
fix: fix incorrect signal on macOS
Browse files Browse the repository at this point in the history
  • Loading branch information
reubeno committed Sep 26, 2024
1 parent 1ea458c commit b1d85e7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
11 changes: 4 additions & 7 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,10 @@ jobs:
artifact_suffix: ""
name_suffix: "(linux)"

#
# TODO: Re-enable once tests are passing.
#
# - host: "macos-latest"
# variant: "macos"
# artifact_suffix: "-macos"
# name_suffix: "(macOS) -- ** not yet expected to pass **"
- host: "macos-latest"
variant: "macos"
artifact_suffix: "-macos"
name_suffix: "(macOS)"

name: "Test ${{ matrix.name_suffix }}"
runs-on: ${{ matrix.host }}
Expand Down
6 changes: 3 additions & 3 deletions brush-core/src/sys/unix/signal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ pub(crate) fn kill_process(pid: u32) -> Result<(), error::Error> {
Ok(())
}

const SIGTSTP: std::os::raw::c_int = 20;

pub(crate) fn tstp_signal_listener() -> Result<tokio::signal::unix::Signal, error::Error> {
let signal = tokio::signal::unix::signal(tokio::signal::unix::SignalKind::from_raw(SIGTSTP))?;
let signal = tokio::signal::unix::signal(tokio::signal::unix::SignalKind::from_raw(
nix::libc::SIGTSTP,
))?;
Ok(signal)
}

Expand Down

0 comments on commit b1d85e7

Please sign in to comment.