Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for relative paths, action failures #136

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Jul 23, 2024

No description provided.

Copy link

Test Results

403 tests   388 ✅  26s ⏱️
 64 suites   15 💤
  8 files      0 ❌

Results for commit 6656f40.

Copy link

Performance Benchmark Report

Benchmark name Baseline (ns) Test/PR (ns) Delta (ns) Delta %
expand_one_string 3606 ns 3603 ns -3 ns 🟢 -0.08%
instantiate_shell 61450 ns 60742 ns -708 ns 🟢 -1.15%
instantiate_shell_with_init_scripts 28814400 ns 28354866 ns -459534 ns 🟢 -1.59%
parse_bash_completion 5534080 ns 5562144 ns +28064 ns 🟠 +0.51%
parse_sample_script 8967 ns 9083 ns +116 ns 🟠 +1.29%
run_echo_builtin_command 96520 ns 93136 ns -3384 ns 🟢 -3.51%
run_one_builtin_command 114784 ns 111500 ns -3284 ns 🟢 -2.86%
run_one_external_command 1999831 ns 2016746 ns +16915 ns 🟠 +0.85%
run_one_external_command_directly 998317 ns 1006781 ns +8464 ns 🟠 +0.85%

Code Coverage Report

Package Base Coverage New Coverage Difference
brush-core/src/arithmetic.rs 🟢 98.6% 🟢 98.6% ⚪ 0%
brush-core/src/builtins.rs 🔴 31.21% 🔴 31.21% ⚪ 0%
brush-core/src/builtins/alias.rs 🟢 83.87% 🟢 83.87% ⚪ 0%
brush-core/src/builtins/bg.rs 🔴 0% 🔴 0% ⚪ 0%
brush-core/src/builtins/break_.rs 🟢 90% 🟢 90% ⚪ 0%
brush-core/src/builtins/builtin_.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/cd.rs 🟢 88.57% 🟢 88.57% ⚪ 0%
brush-core/src/builtins/colon.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/command.rs 🟢 93.26% 🟢 93.26% ⚪ 0%
brush-core/src/builtins/complete.rs 🔴 21.48% 🔴 21.48% ⚪ 0%
brush-core/src/builtins/continue_.rs 🟢 91.67% 🟢 91.67% ⚪ 0%
brush-core/src/builtins/declare.rs 🟢 82.83% 🟢 82.83% ⚪ 0%
brush-core/src/builtins/dirs.rs 🟢 90.48% 🟢 90.48% ⚪ 0%
brush-core/src/builtins/dot.rs 🟢 95.65% 🟢 95.65% ⚪ 0%
brush-core/src/builtins/echo.rs 🟢 86.84% 🟢 86.84% ⚪ 0%
brush-core/src/builtins/enable.rs 🟢 91.07% 🟢 91.07% ⚪ 0%
brush-core/src/builtins/eval.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/exec.rs 🟢 90.32% 🟢 90.32% ⚪ 0%
brush-core/src/builtins/exit.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/export.rs 🟢 88.73% 🟢 88.73% ⚪ 0%
brush-core/src/builtins/factory.rs 🟢 82.2% 🟢 82.2% ⚪ 0%
brush-core/src/builtins/false_.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/fg.rs 🔴 0% 🔴 0% ⚪ 0%
brush-core/src/builtins/getopts.rs 🟢 97.7% 🟢 97.7% ⚪ 0%
brush-core/src/builtins/help.rs 🟢 90.7% 🟢 90.7% ⚪ 0%
brush-core/src/builtins/jobs.rs 🔴 41.86% 🔴 41.86% ⚪ 0%
brush-core/src/builtins/kill.rs 🔴 0% 🔴 0% ⚪ 0%
brush-core/src/builtins/let_.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/popd.rs 🟢 94.12% 🟢 94.12% ⚪ 0%
brush-core/src/builtins/printf.rs 🟢 91.18% 🟢 91.18% ⚪ 0%
brush-core/src/builtins/pushd.rs 🟢 91.3% 🟢 91.3% ⚪ 0%
brush-core/src/builtins/pwd.rs 🟢 89.47% 🟢 89.47% ⚪ 0%
brush-core/src/builtins/read.rs 🟢 76.69% 🟢 76.69% ⚪ 0%
brush-core/src/builtins/return_.rs 🟢 83.33% 🟢 83.33% ⚪ 0%
brush-core/src/builtins/set.rs 🟢 76.64% 🟢 76.64% ⚪ 0%
brush-core/src/builtins/shift.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/shopt.rs 🟢 88.39% 🟢 88.39% ⚪ 0%
brush-core/src/builtins/test.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/trap.rs 🟢 82.95% 🟢 82.95% ⚪ 0%
brush-core/src/builtins/true_.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/builtins/type_.rs 🟢 90.27% 🟢 90.27% ⚪ 0%
brush-core/src/builtins/umask.rs 🔴 0% 🔴 0% ⚪ 0%
brush-core/src/builtins/unalias.rs 🔴 0% 🔴 0% ⚪ 0%
brush-core/src/builtins/unimp.rs 🔴 0% 🔴 0% ⚪ 0%
brush-core/src/builtins/unset.rs 🟢 94.64% 🟢 94.64% ⚪ 0%
brush-core/src/builtins/wait.rs 🟢 85.71% 🟢 85.71% ⚪ 0%
brush-core/src/commands.rs 🟢 92.82% 🟢 92.82% ⚪ 0%
brush-core/src/completion.rs 🔴 42.73% 🔴 42.73% ⚪ 0%
brush-core/src/env.rs 🟢 87.85% 🟢 87.85% ⚪ 0%
brush-core/src/error.rs 🔴 25% 🔴 25% ⚪ 0%
brush-core/src/escape.rs 🔴 14.91% 🔴 14.91% ⚪ 0%
brush-core/src/expansion.rs 🟢 95.95% 🟢 95.95% ⚪ 0%
brush-core/src/extendedtests.rs 🟠 69.2% 🟠 69.2% ⚪ 0%
brush-core/src/functions.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/interp.rs 🟢 93.16% 🟢 92.5% 🔴 -0.66%
brush-core/src/jobs.rs 🔴 43.48% 🔴 41.3% 🔴 -2.18%
brush-core/src/keywords.rs 🟢 96.88% 🟢 96.88% ⚪ 0%
brush-core/src/namedoptions.rs 🟠 51.92% 🟠 51.92% ⚪ 0%
brush-core/src/openfiles.rs 🔴 47.22% 🔴 47.22% ⚪ 0%
brush-core/src/options.rs 🟢 79.17% 🟢 79.17% ⚪ 0%
brush-core/src/patterns.rs 🟢 96.96% 🟢 96.96% ⚪ 0%
brush-core/src/prompt.rs 🟢 78.48% 🟢 78.48% ⚪ 0%
brush-core/src/regex.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/shell.rs 🟢 77.62% 🟢 77.95% 🟢 0.33%
brush-core/src/sys/hostname.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/sys/tokio_process.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/sys/unix/fs.rs 🟠 54.76% 🟠 54.76% ⚪ 0%
brush-core/src/sys/unix/network.rs 🟢 100% 🟢 100% ⚪ 0%
brush-core/src/sys/unix/signal.rs 🔴 40% 🔴 40% ⚪ 0%
brush-core/src/sys/unix/terminal.rs 🔴 0% 🔴 0% ⚪ 0%
brush-core/src/sys/unix/users.rs 🔴 16.13% 🔴 16.13% ⚪ 0%
brush-core/src/tests.rs 🟠 50% 🟠 50% ⚪ 0%
brush-core/src/traps.rs 🟠 50% 🟠 50% ⚪ 0%
brush-core/src/variables.rs 🟢 79.91% 🟢 79.91% ⚪ 0%
brush-interactive/src/interactive_shell.rs 🟢 78.11% 🟢 78.11% ⚪ 0%
brush-parser/src/arithmetic.rs 🟢 100% 🟢 100% ⚪ 0%
brush-parser/src/ast.rs 🔴 24.91% 🔴 24.91% ⚪ 0%
brush-parser/src/error.rs 🟢 76.92% 🟢 76.92% ⚪ 0%
brush-parser/src/parser.rs 🟢 99.6% 🟢 99.6% ⚪ 0%
brush-parser/src/pattern.rs 🟢 100% 🟢 100% ⚪ 0%
brush-parser/src/prompt.rs 🟢 100% 🟢 100% ⚪ 0%
brush-parser/src/test_command.rs 🟢 100% 🟢 100% ⚪ 0%
brush-parser/src/tokenizer.rs 🟢 96.01% 🟢 96.01% ⚪ 0%
brush-parser/src/word.rs 🟢 100% 🟢 100% ⚪ 0%
brush-shell/src/brushctl.rs 🔴 16.67% 🔴 16.67% ⚪ 0%
brush-shell/src/events.rs 🔴 36.96% 🔴 36.96% ⚪ 0%
brush-shell/src/main.rs 🟢 80.43% 🟢 80.43% ⚪ 0%
brush-shell/src/productinfo.rs 🟢 100% 🟢 100% ⚪ 0%
Overall Coverage 🟢 77.4% 🟢 77.34% 🔴 -0.06%

Minimum allowed coverage is 0%, this run produced 77.34%

@reubeno reubeno merged commit 1e95afc into main Jul 23, 2024
10 checks passed
@reubeno reubeno deleted the relative-path-fixes branch July 23, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant