Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid duplicate artifact names #173

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: avoid duplicate artifact names #173

merged 1 commit into from
Sep 26, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Sep 26, 2024

No description provided.

Copy link

Test Results

 24 files  144 suites   58s ⏱️
424 tests 412 ✅ 12 💤 0 ❌
852 runs  824 ✅ 28 💤 0 ❌

Results for commit a58d608.

Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.62 μs 3.62 μs 0.00 μs ⚪ Unchanged
instantiate_shell 59.89 μs 59.37 μs -0.52 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 25484.63 μs 25959.67 μs 475.04 μs ⚪ Unchanged
parse_bash_completion 5653.81 μs 5610.59 μs -43.22 μs 🟢 -0.76%
parse_sample_script 9.04 μs 8.91 μs -0.13 μs 🟢 -1.45%
run_echo_builtin_command 93.96 μs 91.61 μs -2.35 μs 🟢 -2.50%
run_one_builtin_command 113.71 μs 113.87 μs 0.16 μs ⚪ Unchanged
run_one_external_command 1888.72 μs 1855.54 μs -33.18 μs 🟢 -1.76%
run_one_external_command_directly 952.66 μs 953.00 μs 0.34 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/arithmetic.rs 🟢 97.42% 🟢 97.94% 🟢 0.52%
brush-core/src/builtins/command.rs 🟢 91.25% 🟢 91.67% 🟢 0.42%
brush-core/src/builtins/eval.rs 🟢 88.89% 🟢 90.91% 🟢 2.02%
brush-core/src/builtins/factory.rs 🟢 82.2% 🟢 82.35% 🟢 0.15%
brush-core/src/builtins/help.rs 🟢 90.24% 🟢 89.02% 🔴 -1.22%
brush-core/src/builtins/trap.rs 🟠 71.6% 🟠 67.9% 🔴 -3.7%
brush-core/src/commands.rs 🟢 92.82% 🟢 91.48% 🔴 -1.34%
brush-core/src/expansion.rs 🟢 95.71% 🟢 95.29% 🔴 -0.42%
brush-core/src/interp.rs 🟢 89.02% 🟢 89.6% 🟢 0.58%
brush-core/src/jobs.rs 🔴 43.48% 🔴 37.23% 🔴 -6.25%
brush-core/src/openfiles.rs 🔴 47.92% 🔴 47.71% 🔴 -0.21%
brush-core/src/processes.rs 🔴 0% 🟠 54.55% 🟢 54.55%
brush-core/src/shell.rs 🟢 78.06% 🟢 77.74% 🔴 -0.32%
brush-core/src/sys/unix/signal.rs 🔴 40% 🟠 67.65% 🟢 27.65%
brush-core/src/sys/unix/terminal.rs 🔴 0% 🔴 36.07% 🟢 36.07%
brush-core/src/terminal.rs 🔴 0% 🟢 100% 🟢 100%
brush-interactive/src/interactive_shell.rs 🟠 66.1% 🟠 66.67% 🟢 0.57%
brush-shell/src/events.rs 🔴 37.23% 🔴 36.46% 🔴 -0.77%
Overall Coverage 🟢 76.51% 🟢 75.99% 🔴 -0.52%

Minimum allowed coverage is 70%, this run produced 75.99%

@reubeno reubeno merged commit 2f1acd6 into main Sep 26, 2024
11 checks passed
@reubeno reubeno deleted the fix-ci branch September 26, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant