Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable setting min oracle version on tests #184

Merged
merged 1 commit into from
Oct 2, 2024
Merged

test: enable setting min oracle version on tests #184

merged 1 commit into from
Oct 2, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Oct 2, 2024

This enables us to tag certain tests as only being applicable when a given minimum version of the oracle (i.e., bash) is installed on the test system. This is practically useful since we now have a few tests that pass when comparing brush to bash only when bash is >= 5.2.

Copy link

github-actions bot commented Oct 2, 2024

Test Results

  2 files    8 suites   52s ⏱️
424 tests 424 ✅ 0 💤 0 ❌
848 runs  848 ✅ 0 💤 0 ❌

Results for commit 3b6bf06.

Copy link

github-actions bot commented Oct 2, 2024

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.36 μs 3.36 μs -0.00 μs ⚪ Unchanged
instantiate_shell 59.29 μs 59.48 μs 0.19 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 26946.94 μs 25609.38 μs -1337.56 μs 🟢 -4.96%
parse_bash_completion 5690.30 μs 5769.97 μs 79.67 μs 🟠 +1.40%
parse_sample_script 9.09 μs 9.21 μs 0.12 μs 🟠 +1.26%
run_echo_builtin_command 92.17 μs 90.55 μs -1.62 μs ⚪ Unchanged
run_one_builtin_command 113.57 μs 111.86 μs -1.71 μs ⚪ Unchanged
run_one_external_command 1871.18 μs 1852.33 μs -18.85 μs ⚪ Unchanged
run_one_external_command_directly 966.15 μs 958.98 μs -7.17 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/jobs.rs 🔴 42.42% 🔴 37.23% 🔴 -5.19%
Overall Coverage 🟢 76.21% 🟢 76.11% 🔴 -0.1%

Minimum allowed coverage is 70%, this run produced 76.11%

@reubeno reubeno merged commit 00d2f64 into main Oct 2, 2024
11 checks passed
@reubeno reubeno deleted the min-ver branch October 2, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant