Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address issues with array unset #211

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: address issues with array unset #211

merged 1 commit into from
Oct 17, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Oct 17, 2024

Also address parse issues with complex array index expressions.

Copy link

Test Results

  2 files    9 suites   1m 14s ⏱️
474 tests 474 ✅ 0 💤 0 ❌
939 runs  939 ✅ 0 💤 0 ❌

Results for commit dadee77.

Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.41 μs 3.42 μs 0.00 μs ⚪ Unchanged
instantiate_shell 60.41 μs 59.71 μs -0.70 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 27814.58 μs 28622.15 μs 807.57 μs 🟠 +2.90%
parse_bash_completion 2642.06 μs 2650.22 μs 8.16 μs ⚪ Unchanged
parse_sample_script 3.91 μs 3.91 μs 0.00 μs ⚪ Unchanged
run_echo_builtin_command 90.84 μs 90.36 μs -0.48 μs ⚪ Unchanged
run_one_builtin_command 108.24 μs 109.63 μs 1.39 μs ⚪ Unchanged
run_one_external_command 2003.25 μs 1931.97 μs -71.29 μs 🟢 -3.56%
run_one_external_command_directly 1013.04 μs 1012.66 μs -0.38 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/unset.rs 🟢 82.61% 🟢 82.98% 🟢 0.37%
brush-core/src/jobs.rs 🔴 37.23% 🔴 42.42% 🟢 5.19%
brush-core/src/shell.rs 🟢 82.55% 🟢 83.4% 🟢 0.85%
Overall Coverage 🟢 75.44% 🟢 75.57% 🟢 0.13%

Minimum allowed coverage is 70%, this run produced 75.57%

@reubeno reubeno merged commit f90f73d into main Oct 17, 2024
11 checks passed
@reubeno reubeno deleted the unset-fixes branch October 17, 2024 00:43
39555 pushed a commit to 39555/brush that referenced this pull request Oct 22, 2024
* Enable unset of elements within an array using complex index expressions
* Fix parse issues with more complex array index expressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant