Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leave trailing whitespace out of reedline completion suggestions #214

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Oct 17, 2024

In the future we can simplify this (rather than having to postprocess the candidates), but this is a more targeted fix that works for now without a bit of refactoring.

Copy link

Test Results

  2 files    9 suites   1m 2s ⏱️
478 tests 478 ✅ 0 💤 0 ❌
947 runs  947 ✅ 0 💤 0 ❌

Results for commit d66702f.

Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.42 μs 3.42 μs 0.00 μs ⚪ Unchanged
instantiate_shell 60.08 μs 59.78 μs -0.30 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 27915.57 μs 28678.17 μs 762.60 μs 🟠 +2.73%
parse_bash_completion 2699.80 μs 2727.75 μs 27.95 μs ⚪ Unchanged
parse_sample_script 3.99 μs 4.08 μs 0.09 μs 🟠 +2.36%
run_echo_builtin_command 91.19 μs 89.78 μs -1.41 μs ⚪ Unchanged
run_one_builtin_command 108.10 μs 107.99 μs -0.11 μs ⚪ Unchanged
run_one_external_command 1968.60 μs 2059.99 μs 91.40 μs 🟠 +4.64%
run_one_external_command_directly 1005.46 μs 1013.99 μs 8.54 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/shell.rs 🟢 78.4% 🟢 78.54% 🟢 0.14%
Overall Coverage 🟢 72.67% 🟢 72.66% 🔴 -0.01%

Minimum allowed coverage is 70%, this run produced 72.66%

@reubeno reubeno merged commit 1dc38e3 into main Oct 17, 2024
11 checks passed
@reubeno reubeno deleted the reedline-whitespace branch October 17, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant