Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement support for ;;& and ;& in case items #223

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Oct 24, 2024

Implements support for bash extensions to case item terminators: ;;& and ;&.

Fixes one of the issues tracked by #222.

Copy link

Test Results

  2 files    9 suites   1m 2s ⏱️
481 tests 481 ✅ 0 💤 0 ❌
953 runs  953 ✅ 0 💤 0 ❌

Results for commit 5d794f4.

Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.42 μs 3.42 μs -0.00 μs ⚪ Unchanged
instantiate_shell 59.77 μs 59.40 μs -0.37 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 30386.84 μs 30436.68 μs 49.84 μs ⚪ Unchanged
parse_bash_completion 2769.17 μs 2759.15 μs -10.03 μs ⚪ Unchanged
parse_sample_script 4.28 μs 4.21 μs -0.07 μs ⚪ Unchanged
run_echo_builtin_command 88.81 μs 89.57 μs 0.76 μs ⚪ Unchanged
run_one_builtin_command 107.68 μs 108.18 μs 0.50 μs ⚪ Unchanged
run_one_external_command 2052.96 μs 1986.42 μs -66.55 μs 🟢 -3.24%
run_one_external_command_directly 1010.26 μs 1005.66 μs -4.60 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/interp.rs 🟢 90.02% 🟢 90.13% 🟢 0.11%
brush-core/src/jobs.rs 🔴 37.23% 🔴 42.42% 🟢 5.19%
brush-core/src/patterns.rs 🟢 97.77% 🟢 97.78% 🟢 0.01%
brush-core/src/shell.rs 🟢 78.11% 🟢 78.54% 🟢 0.43%
brush-parser/src/ast.rs 🔴 25.66% 🔴 25.35% 🔴 -0.31%
brush-parser/src/parser.rs 🟢 99.74% 🟢 99.75% 🟢 0.01%
brush-shell/src/main.rs 🟢 90.2% 🟢 90.85% 🟢 0.65%
Overall Coverage 🟢 73.33% 🟢 73.45% 🟢 0.12%

Minimum allowed coverage is 70%, this run produced 73.45%

@reubeno reubeno merged commit 733eff4 into main Oct 24, 2024
11 checks passed
@reubeno reubeno deleted the impl-other-dsemis branch October 24, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant