Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove unneeded async from arithmetic eval #312

Merged
merged 1 commit into from
Jan 9, 2025
Merged

perf: remove unneeded async from arithmetic eval #312

merged 1 commit into from
Jan 9, 2025

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Jan 9, 2025

No description provided.

Copy link

github-actions bot commented Jan 9, 2025

Test Results

    2 files      9 suites   1m 20s ⏱️
  574 tests   574 ✅ 0 💤 0 ❌
1 134 runs  1 134 ✅ 0 💤 0 ❌

Results for commit c024ebf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 9, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 19.53 μs 19.54 μs 0.01 μs ⚪ Unchanged
eval_arithmetic 0.44 μs 0.21 μs -0.22 μs 🟢 -50.80%
expand_one_string 2.38 μs 2.29 μs -0.10 μs ⚪ Unchanged
for_loop 62.84 μs 64.80 μs 1.96 μs ⚪ Unchanged
function_call 5.06 μs 5.12 μs 0.05 μs ⚪ Unchanged
instantiate_shell 61.77 μs 64.86 μs 3.10 μs 🟠 +5.02%
instantiate_shell_with_init_scripts 29781.40 μs 28995.67 μs -785.73 μs 🟢 -2.64%
parse_bash_completion 2868.26 μs 2846.95 μs -21.31 μs ⚪ Unchanged
parse_sample_script 4.36 μs 4.36 μs -0.00 μs ⚪ Unchanged
run_echo_builtin_command 22.25 μs 22.21 μs -0.04 μs ⚪ Unchanged
run_one_external_command 1840.91 μs 1579.97 μs -260.94 μs 🟢 -14.17%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/arithmetic.rs 🟢 98.45% 🟢 98.4% 🔴 -0.05%
brush-core/src/jobs.rs 🔴 37.07% 🔴 43.1% 🟢 6.03%
brush-core/src/shell.rs 🟢 82.29% 🟢 82.4% 🟢 0.11%
Overall Coverage 🟢 76.6% 🟢 76.68% 🟢 0.08%

Minimum allowed coverage is 70%, this run produced 76.68%

@reubeno reubeno changed the title chore: remove unneeded async perf: remove unneeded async from arithmetic eval Jan 9, 2025
@reubeno reubeno marked this pull request as ready for review January 9, 2025 09:12
@reubeno reubeno merged commit 379e1bf into main Jan 9, 2025
17 checks passed
@reubeno reubeno deleted the un-async branch January 9, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant