Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Drop Python 3.3 Support #60

Merged
merged 2 commits into from
Oct 18, 2017
Merged

🔥 Drop Python 3.3 Support #60

merged 2 commits into from
Oct 18, 2017

Conversation

jefftriplett
Copy link
Member

Since Python 3.3 is no longer maintained and it's usage is next to nothing, we might as well speed up our test suite by dropping support for it. See notes here for how small it's usage was a year+ ago: pypa/pip#3796

@fcurella
Copy link
Collaborator

should we also drop django <1.8?

@coveralls
Copy link

coveralls commented Oct 17, 2017

Coverage Status

Coverage remained the same at 97.112% when pulling 7659414 on drop-python-3-3 into c3117b2 on master.

@jefftriplett
Copy link
Member Author

@fcurella there's a good argument to be made for it. I'm not really sure what our user base is. I felt good about dropping Python 3 since python.org stopped supporting it.

The release chart with the dates of the old versions kind of puts it into perspective: https://www.djangoproject.com/download/#supported-versions

I don't think it hurts to support some older versions but I'm not sure where that line is. Do you or
@frankwiles have strong feelings about it?

@fcurella
Copy link
Collaborator

fcurella commented Oct 17, 2017

I'd say let's support one LTS before the currently supported one (which currently 'resolves' to 1.8+). That should give enough time to upgrade even for the most conservative of our users.

And when django 2.2 will be out, we can drop < 1.11

@goodtune
Copy link
Contributor

I'd go so far as to drop the non-LTS versions that have gone out of support (1.9 already, 1.10 at years end) on the basis that older releases of django-test-plus will still be available to support older projects.

I wouldn't go hard at making breaking changes, just stop certifying against unsupported versions of Django as early as possible.

@jefftriplett
Copy link
Member Author

jefftriplett commented Oct 18, 2017

I'm personally +1 for making a new PR to just target Django versions to keep this relatively focused scope.

I'm +1 for supporting both LTSs when it makes sense. I'm +0 supporting 1.9 and 1.10 if we get those for free already and a lot of people are still on them.

@frankwiles
Copy link
Member

Yeah let's definitely drop <1.8 as it really shouldn't matter much.

I think we should continue to test 1.8+ until we run into a situation where we cannot support 1.9 or 1.10. This way we'll see if/when it breaks and can make a note in the docs about "If you need Django 1.9.x you have to use before dtp version <= x.y.z". But we'll ditch support for anything not supported upstream at the first issue and not work around it.

Make sense?

@jefftriplett
Copy link
Member Author

Please refer to #62 for that followup.

@jefftriplett jefftriplett merged commit cd4500d into master Oct 18, 2017
@jefftriplett jefftriplett deleted the drop-python-3-3 branch October 18, 2017 15:33
@goodtune
Copy link
Contributor

All good with @frankwiles approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants