-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Drop Python 3.3 Support #60
Conversation
Signed-off-by: Jeff Triplett <[email protected]>
Signed-off-by: Jeff Triplett <[email protected]>
should we also drop django <1.8? |
@fcurella there's a good argument to be made for it. I'm not really sure what our user base is. I felt good about dropping Python 3 since python.org stopped supporting it. The release chart with the dates of the old versions kind of puts it into perspective: https://www.djangoproject.com/download/#supported-versions I don't think it hurts to support some older versions but I'm not sure where that line is. Do you or |
I'd go so far as to drop the non-LTS versions that have gone out of support (1.9 already, 1.10 at years end) on the basis that older releases of django-test-plus will still be available to support older projects. I wouldn't go hard at making breaking changes, just stop certifying against unsupported versions of Django as early as possible. |
I'm personally +1 for making a new PR to just target Django versions to keep this relatively focused scope. I'm +1 for supporting both LTSs when it makes sense. I'm +0 supporting 1.9 and 1.10 if we get those for free already and a lot of people are still on them. |
Yeah let's definitely drop <1.8 as it really shouldn't matter much. I think we should continue to test 1.8+ until we run into a situation where we cannot support 1.9 or 1.10. This way we'll see if/when it breaks and can make a note in the docs about "If you need Django 1.9.x you have to use before dtp version <= x.y.z". But we'll ditch support for anything not supported upstream at the first issue and not work around it. Make sense? |
Please refer to #62 for that followup. |
All good with @frankwiles approach. |
Since Python 3.3 is no longer maintained and it's usage is next to nothing, we might as well speed up our test suite by dropping support for it. See notes here for how small it's usage was a year+ ago: pypa/pip#3796