fix: update ESM output to increase interop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
commented
Mar 21, 2024
| }, | ||
| "license": "MIT", | ||
| "author": "Espen Hovlandsdal <[email protected]>", | ||
| "sideEffects": false, |
There was a problem hiding this comment.
This helps treeshaking in bundlers like rollup and webpack
stipsan
commented
Mar 22, 2024
Comment on lines
-8
to
-11
| "node": { | ||
| "import": "./dist/use-hot-module-reload.esm.mjs", | ||
| "require": "./dist/use-hot-module-reload.cjs.js" | ||
| }, |
There was a problem hiding this comment.
These are not needed since they resolve to the same files as the upper level require and import conditions
stipsan
commented
Mar 22, 2024
| @@ -3,8 +3,7 @@ | |||
| "compilerOptions": { | |||
| "outDir": "lib", | |||
| "strict": true, | |||
| "esModuleInterop": true, | |||
| "module": "ES2020", | |||
| "module": "Preserve", | |||
There was a problem hiding this comment.
esModuleInterop is true when using module: preserve. More details: microsoft/TypeScript#56785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it a
type: modulepackage, which has higher ecosystem interop than the legacy behaviour of treating.jsfiles as CJS.