Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: emit is loading when resource come from memory #217

Merged
merged 9 commits into from
Sep 12, 2019
Merged

Fix: emit is loading when resource come from memory #217

merged 9 commits into from
Sep 12, 2019

Conversation

pablorsk
Copy link
Member

Fixes:

  • Emit from memory before is_loading=true.
  • loaded attribute added to resource and collections. is_loading deprecated since 2.2.0.
  • Set loaded and builded, set any child hasMany relationship

@coveralls
Copy link

coveralls commented Sep 12, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 65.795% when pulling d2c1399 on fix/emit_is_loading_when_resource_come_from_memory into 8c0edc4 on v2.1.

@pablorsk pablorsk merged commit af7db15 into v2.1 Sep 12, 2019
@pablorsk
Copy link
Member Author

fix #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablorsk @coveralls