Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document delete confirm button is not visible in deleting dialog of query results #93

Closed
2 tasks done
maoxuner opened this issue Nov 4, 2023 · 1 comment
Closed
2 tasks done

Document delete confirm button is not visible in deleting dialog of query results #93

maoxuner opened this issue Nov 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@maoxuner
Copy link

maoxuner commented Nov 4, 2023 •
edited by riccox
Loading

Describe the bug

  • Delete button translation error in query results list
  • Delete button not visible in deleting dialog of query results

To Reproduce
Steps to reproduce the behavior:

  1. Connect to a meilisearch instance from demo site https://meilisearch-ui.riccox.com/
  2. Select any index which has documents, point to right bottom corner of the list, then actions buttons shown
  3. Delete button shown at prev step was not translate (screenshot 1)
  4. Click the "delete button", then the dialog shown
  5. The confirm button is not visible (screenshot 2)

Expected behavior

  1. delete button traslated
  2. confirm button shown

Screenshots
1

2

Environments (please complete the following information):

  • OS: archlinux
  • Browser chrome
  • Version 119.0.6045.105 (x64)

Additional context
related issue #82
@maoxuner maoxuner added the bug Something isn't working label Nov 4, 2023
@maoxuner maoxuner mentioned this issue Nov 4, 2023
Closed
@riccox riccox moved this to 👁 In Progress in Meilisearch-UI Roadmap Nov 4, 2023
riccox added a commit that referenced this issue Nov 4, 2023
@riccox
fix: confirm btn is not visible in modals gh-93.
709299f
riccox added a commit that referenced this issue Nov 4, 2023
@riccox
fix: confirm btn is not visible in modals gh-93.
8f30187 
perf: change document card font size.
perf: document card btn style.
fix: document card btn translation text.
@riccox riccox mentioned this issue Nov 4, 2023
Merged
@riccox
Copy link
Owner

riccox commented Nov 4, 2023

@maoxuner Thanks!
Fixed in new release version v0.6.8.

It will take some time to run ci, you can try online demo & latest docker image after ci finished.

@riccox riccox closed this as completed Nov 4, 2023
@github-project-automation github-project-automation bot moved this from 👁 In Progress to 🍻 Done in Meilisearch-UI Roadmap Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Meilisearch-UI Roadmap
Status: 🍻 Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riccox @maoxuner