Faster clear() method for RDS storrs and drivers #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the original proposal in #121 (comment).
Changes
clear()
method, which usesunlink(recursive = TRUE)
instead of deleting keys one by one from R.clear()
method in thestorr
base class looks for a driver'sclear()
method first, then defaults to deleting keys one by one if the driver has no such method.clear()
in RDS drivers isinteger(0)
instead of the number of deleted keys.Benchmarks
We see the speed improvements we expected from #121 (comment).
Created on 2020-03-15 by the reprex package (v0.3.0)