feat: QVM API module #289
Merged
feat: QVM API module #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarquessV
commented
May 3, 2023
Co-authored-by: jselig-rigetti <[email protected]>
Co-authored-by: jselig-rigetti <[email protected]>
multishot, expectation, and wavefunction requests as direct calls to the QVM API. The parameterized `run` and `run_program` functions have been lifted into the root of the QVM module.
names to a value describing whether to get all, none, or a specific list of indices for the address.
MarquessV
commented
May 17, 2023
MarquessV
commented
May 17, 2023
stubtest to default dev flow and resolve all stubtest issues
MarquessV
commented
May 22, 2023
Shadow53
previously requested changes
May 22, 2023
There was a problem hiding this comment.
Left some notes. A lot of comments were saved from when I started to review last week and might be outdated, though I tried to look for those.
Biggest thing is a spot where we are shifting elements in a Vec a lot, with a suggestion on how to rewrite it.
I did not go through the Python/PyO3 stuff as carefully as I would have liked, but nothing stood out there.
QvmResponse into Result
allowing for easy parameterization of Programs before running on the QVM.
Shadow53
reviewed
May 24, 2023
jselig-rigetti
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building up a QVM API that has feature parity with pyQuil's QVM client. This meant adding types and functions to support three additional request types. The
qvm::apimodule contains all the types and functions to more or less directly interact with the QVM, while theqvm::runandqvm::run_programfunctions exist as a higher level means to support parameterized execution of a program on the QVM.I also fixed some issues with building the bindings as a Rust crate, added a stubtest task, and resolved all the existing stubtest issue.