Cherry-pick #343 #348 and #345 to release-1.2 #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capossele
approved these changes
Dec 3, 2024
|
Looks like we need to work around a version issue |
nategraf
force-pushed
the
victor/release-1.2-cherry-pick-dec2
branch
from
bfc6e4f to
c0a3048
Compare
nategraf
changed the base branch from
release-1.2
to
victor/bump-release-1.2.0
|
I really cannot figure out why |
|
This PR will land onto |
- Artifacts actions `@v3` being deprecated. - All `actions/upload-artifact` and `actions/download-artifact` uses must be upgraded to `@v4` before brownout dates in January: - https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/ <img src="https://github.com/user-attachments/assets/e1f86962-652f-46ac-a35d-2a9eb7c1db34" width="400"/>
I started seeing the following errors in our CI, and realized that we do not apply `--locked` when building `cargo-risczero` from `main`. This would be good to help with stability of CI. https://github.com/risc0/risc0-ethereum/actions/runs/12078623988/job/33683295704?pr=346
Add script and instructions to deploy the set verifier --------- Co-authored-by: Victor Graf <[email protected]>
nategraf
force-pushed
the
victor/release-1.2-cherry-pick-dec2
branch
from
c0a3048 to
51287fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@v3to@v4(WEB3-243: Upgrade Artifacts Actions using@v3to@v4#343)