-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced earley by pacomb in the "metavar" example #26
Conversation
Just the pacomb does not have (yet) a predefined blank notion with opening/closing comments. It is always tricky
If you know how to write a conditional opam file that does not force the user to install 3 parsing technologies. I still like more pacomb or earley because the parser is both readable and inside the file. By the way I wanted to make a compile time version of earley that would not allow dynamical grammar but that could be faster than camlyacc and menhir. |
Remark: we needed the lateest pacomb which is not on opam. I fixed that, but I think we need the metavar test to run. I am adding this. |
You'll need to rebase your MR on master, with something like |
bindlib and metatar tests work on 4.07, but with deps Timed >= 1.0, opam is not able to select Timed 1.0 on ocaml 4.07 and 1.1 on 4.08 and more recent. If you know how to fix that (or fix Timed 1.1), we can put back 4.07 support. |
All test run. I stop for now, you may review when you have time and try to recover 4.07, it is not nice to loose a version just because of Timed used in one example. Cheers. |
21c79c3
to
787a7e5
Compare
Hello Rodolphe ... I just did a PR on top of that one for issue #29. Do you think we should merge that one, or there is still some adjustment ? |
I don't remember where this is at, I thought I was waiting for changes on your side. I'll have a closer look when I have a moment. |
I think the only thing to do was recover 4.07, and it seems to work now. I just needed to ask for dune 2.0, not 2.7, but it seems to work. |
1de32b2
to
f051a0a
Compare
On en est où avec cette PR... |
Aucune idée, j'ai perdu tout contexte. Je regarderai à nouveau quand j'ai un moment. |
f051a0a
to
3f816be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Thanks to this PR bindlib and its examples compile under ocaml 5.0