Use a manual timeout implementation in Analysis to handle I/O gracefully #5263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout::timeout
may interrupt I/O operations leading to messed up connection handles. By implementing the timeout in Ruby instead, we can be sure that I/O operations will have terminated cleanly.Downsides: a long-running I/O operation will not be killed halfway through. To mitigate this, you'll need timeouts on your client libraries themselves. Also, the timeout is only checked periodically so it's not 100% accurate (runtime may be a tiny bit longer than the timeout).
Also I removed
on_fragment_definition
. This is because thesuper(query.selected_operation)
line indef initialize
means that fragment definitions are never actually visited. I discovered this because I added acheck_timeout
to the olddef on_fragment_definition
and I couldn't get a test to fail for it 🤦part of #5261