Remove unnecessary connection from faceRecognizer #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
force-pushed
the
fix/faceRecognizer-comm
branch
6 times, most recently
from
3a0c203 to
2f82b41
Compare
vvasco
force-pushed
the
fix/faceRecognizer-comm
branch
from
2f82b41 to
1f4a06f
Compare
|
Tested on the robot and working! |
vvasco
approved these changes
Jan 17, 2019
|
@vtikha do you agree if we merge this PR? Be aware that, aside from the modifications required to get rid of the connection, there are also parts of the code to deal with the images according to the new Incidentally, upgrading the user code to make it use |
faceRecognizer was receiving twice the same images from yarpOpenPose fix #134
vvasco
force-pushed
the
fix/faceRecognizer-comm
branch
from
dff052e to
3f58337
Compare
|
@vtikha gave the green light 🚥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #134.
To spare one unnecessary connection,
faceRecognizermain thread can now callQueryThread::setImage()to pass the received image on to theQueryThread, which in turn can handle safely the image relying onQueryThread::getImage().Note the use of
yarp::cv::toCvMat()introduced by robotology/yarp#1932.cc @vtikha @vvasco