Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss76 - Add template class for fixed-size Vector (size known at compile time) #77

Closed
wants to merge 2 commits into from

Conversation

andreadelprete
Copy link

Comments on the implemented feature can be found here: #76

@paulfitz
Copy link
Member

paulfitz commented Oct 7, 2013

@andreadelprete works for me. Could you move the Vector1, Vector2, ... typedefs into the yarp::sig namespace? @lornat75 as author of a lot of the original code do you have any comments?

@lornat75
Copy link
Member

lornat75 commented Oct 7, 2013

Speaking with Andrea I am fine with the solution he proposes. One recommendation is to add lots of tests because templates are nasty as we all know ☺

@paulfitz
Copy link
Member

@andreadelprete just as a reminder, I'd happily merge this once the Vector1, Vector2, etc typedefs are moved out of the global namespace.

@andreadelprete
Copy link
Author

@paulfitz Sorry for the delay in replying, I was out of office last week. As I wrote in #76 I think this design (VectorN inherits from Vector) doesn't work well, so I'm gonna switch to the second solution (Vector inherits from VectorN) or to the solution you proposed (both Vector and VectorN inherit from VectorBase).

@paulfitz
Copy link
Member

Ok, understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants