Convert Travis to GitHub actions #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 10, 2020 22:43
Based on the implementation in rollbar-php, this attempts to mimic the existing Travis CI configuration.
In the last green Travis build[1], coveralls failed with "command not found". We fixed that particular error in this build but there are still missing environment variables. Since the scope of this change is to replace the existing Travis behavior, we'll stop here and let the coveralls fail but ignore that fact. [1]:https://travis-ci.org/github/rollbar/rollbar-php-laravel/jobs/743942091
|
@waltjones and @mrunalk -- Ready for review. |
bishopb
force-pushed
the
chore/CH-76807/travis-to-github-action
branch
from
af839b3 to
044f08c
Compare
mrunalk
reviewed
Dec 18, 2020
| php-tests: | ||
| strategy: | ||
| matrix: | ||
| php: [7.3, 7.2] |
There was a problem hiding this comment.
@mrunalk I'm keeping the scope narrow on this PR, specifically to emulate the original Travis behavior as closely as possible. Since the original Travis definition tested only on 7.3 and 7.2, I have retained that compatibility. Future releases will sort all this out, so that all documented versions will be under test. That's a bigger fish to fry, so I'm doing that in chunks.
mrunalk
approved these changes
Dec 19, 2020
| php-tests: | ||
| strategy: | ||
| matrix: | ||
| php: [7.3, 7.2] |
waltjones
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Based on the implementation in rollbar-php, this mimics the existing Travis CI configuration. We ignore certain unfortunate facts, like we're not testing on 7.4 and coveralls fails. Refer to the last green Travis build.
Type of change
\
Checklists
Development
Code review