Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in php version array #127

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This fixes a typo in the main CI GitHub Action. Each PHP version in the array should be separated by a comma.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Bug Fix a component so that its behavior aligns with its documentation. label Feb 23, 2022
@danielmorell danielmorell marked this pull request as draft February 23, 2022 16:52
@danielmorell
Copy link
Collaborator Author

This build is going to fail because our dependency chain is not compatible with PHP 8. We need psr/log to be at least v2 or above. However, we are depending on rollbar/rollbar v2 which requires psr/log v1 and PHP 7.

I initially marked this as a draft after the build failed to verify there were not any other issues in our CI pipeline. However, now that I know we need to get our version of rollbar/rollbar to v3 to make this work I will create a separate branch/PR to contain the scope of that work.

@danielmorell danielmorell marked this pull request as ready for review February 23, 2022 17:33
@danielmorell danielmorell merged commit a6c803d into rollbar:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants