-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
The failure of Travis CI is not related to this Pull Request |
@tmaier that's great! I followed a similar approach in my Can you also add a couple of words in the readme? If this is merged as is, people will not know how to use the Docker image :) |
Hi @axilleas, Do you know if there are any constraints on the E-Mail-Adress to use for Let's Encrypt? |
- Docker image - Automatic renewal of the certificate
Please review the updated README at https://github.com/tmaier/gitlab-letsencrypt/blob/master/README.markdown |
Switch to the node user temporarily for npm install and uninstall all build dependencies
The latest commit reduces the docker image size from 92 MB to 20 MB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmaier that's great! I left a couple of comments.
README.markdown
Outdated
|
||
Add the following variables to your GitLab project: `LETS_ENCRYPT_EMAIL` and your secret `GITLAB_TOKEN`. | ||
|
||
Schedule then a new pipeline to run for example every month. See <https://docs.gitlab.com/ce/user/project/pipelines/schedules.html> for details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing period :)
There is also a [Docker image](https://hub.docker.com/r/rolodato/gitlab-letsencrypt/) available. | ||
This means the Command-line tool can be used without installing all the dependencies required to run the application. | ||
|
||
Example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave a newline here? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? I think there is a newline due to the code block following this line
README.markdown
Outdated
image: | ||
name: rolodato/gitlab-letsencrypt | ||
entrypoint: ["/bin/sh", "-c"] | ||
stage: deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be run after the site build right? Maybe add a note about the stage naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not really matter in which stage it runs. I would recommend to add to all other jobs except: [schedules]
, as the next build will be triggered by gitlab-le anyway
I'm not aware of anything about this. I guess we can use this variable :) |
- Remove stage, as it is not relevant - Recommend to skip all other jobs when scheduled pipeline is running - Improve formatting of YAML - Skip cloning the git repository
Hey, thanks for putting this together! Seems like a great way to solve the automation problem. I'm not sure I'd like to maintain this though, since I am not very familiar with Docker. If you don't mind, I'd rather keep this on a separate repository (your fork or any other repo would be fine) and I can link to it from the Setup and Automation section of the README. That way it's still available for anyone who is interested. What do you think? |
Whalebrew is like Homebrew (Mac), only using Docker instead See https://github.com/bfirsh/whalebrew
Hi @rolodato, normally, I would like to keep it within this repo, as for me Docker support and this kind of integration with GitLab CI belong directly to this repo and the scope of the tool. But I understand your concern. If I remove the Dockerfile, shall I keep the changes to the README in this form or another? Under which cirumstances would you be ready to have the Dockerfile inside this repository? For example, do the maintainer labels in the Dockerfile help? Or if there would be contribution guidelines which states that Docker is not supported and that questions on Docker+gitlab-le shall be placed on StackOverflow? |
[ci skip]
Hi @tmaier, sorry for the delay getting back to you.
I would just leave a link to the Dockerfile in the Automation section, wherever it ends up being hosted (your repo or anywhere else is fine).
As I mentioned in my previous comment, since I'm not very familiar with Docker in general, I would prefer to leave the Dockerfile for others to maintain. Even if Dockerfiles have some way of defining external maintainers, I would still need to manage pull requests and issues for the Dockerfile if it ends up on this repository. In short, please publish the Dockerfile yourself, with a README or other instructions if you'd like, and I'd be happy to link them from this repo's README. Thanks! |
Run gitlab-le within a docker container.
After merging this, set up a docker repository like this one: https://hub.docker.com/r/tmaier/gitlab-letsencrypt/
node
Use the following command:
Schedule a job with GitLab CI:
Note: you need to set
GITLAB_TOKEN
as variable and you need to enable the Pipeline Schedule