Skip to content

Commit

Permalink
feat: Remove ErrorDecode type
Browse files Browse the repository at this point in the history
  • Loading branch information
@romshark
romshark committed Mar 21, 2024
1 parent 40a6f21 commit dd5e400
Show file tree
Hide file tree
Showing 12 changed files with 710 additions and 1,105 deletions.
4 changes: 2 additions & 2 deletions bench/any_complex_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func TestImplementationsAnyComplex(t *testing.T) {
}
require.NoError(t, err)
var v any
if err := d.Decode([]byte(in), &v, opts); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, opts); err != nil {
t.Fatal(err)
}
require.Equal(t, expect(), v)
Expand Down Expand Up @@ -196,7 +196,7 @@ func BenchmarkDecodeAnyComplex(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v any
if err := d.Decode(in, &v, opts); err.IsErr() {
if _, err := d.Decode(in, &v, opts); err != nil {
b.Fatal(err)
}
}
Expand Down
4 changes: 2 additions & 2 deletions bench/any_int_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func TestImplementationsAnyInt(t *testing.T) {
)
require.NoError(t, err)
var v any
if err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err != nil {
t.Fatal(err)
}
require.Equal(t, expect, v)
Expand Down Expand Up @@ -164,7 +164,7 @@ func BenchmarkAnyInt(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v any
if err := d.Decode(in, &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode(in, &v, jscandec.DefaultOptions); err != nil {
b.Fatal(err)
}
}
Expand Down
4 changes: 2 additions & 2 deletions bench/array_2d_bool_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func TestImplementationsDecode2DArrayBool(t *testing.T) {
)
require.NoError(t, err)
var v [][]bool
if err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err != nil {
t.Fatal(err)
}
require.Equal(t, expect(), v)
Expand Down Expand Up @@ -167,7 +167,7 @@ func BenchmarkDecode2DArrayBool(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v [][]bool
if err := d.Decode(in, &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode(in, &v, jscandec.DefaultOptions); err != nil {
b.Fatal(err)
}
}
Expand Down
4 changes: 2 additions & 2 deletions bench/array_int_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func TestImplementationsDecodeArrayInt(t *testing.T) {
)
require.NoError(t, err)
var v []int
if err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err != nil {
t.Fatal(err)
}
require.Equal(t, expect, v)
Expand Down Expand Up @@ -178,7 +178,7 @@ func BenchmarkDecodeArrayInt12K(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v []int
if err := d.Decode(in, &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode(in, &v, jscandec.DefaultOptions); err != nil {
b.Fatal(err)
}
}
Expand Down
4 changes: 2 additions & 2 deletions bench/array_ptr_int_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func TestImplementationsPtrInt(t *testing.T) {
)
require.NoError(t, err)
var v *int
if err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err != nil {
t.Fatal(err)
}
require.Equal(t, expect(), v)
Expand Down Expand Up @@ -170,7 +170,7 @@ func BenchmarkPtrInt(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v *int
if err := d.Decode(in, &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode(in, &v, jscandec.DefaultOptions); err != nil {
b.Fatal(err)
}
}
Expand Down
4 changes: 2 additions & 2 deletions bench/array_string_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func TestImplementationsDecodeArrayString(t *testing.T) {
)
require.NoError(t, err)
var v []string
if err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err != nil {
t.Fatal(err)
}
require.Equal(t, expect(), v)
Expand Down Expand Up @@ -181,7 +181,7 @@ func BenchmarkDecodeArrayString(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v []string
if err := d.Decode(in, &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode(in, &v, jscandec.DefaultOptions); err != nil {
b.Fatal(err)
}
runtime.KeepAlive(v)
Expand Down
4 changes: 2 additions & 2 deletions bench/map_int_map_string_struct3_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func TestImplementationsMapIntMapStringStruct3(t *testing.T) {
)
require.NoError(t, err)
var v map[int]map[string]bench.Struct3
if err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err != nil {
t.Fatal(err)
}
require.Equal(t, expect(), v)
Expand Down Expand Up @@ -249,7 +249,7 @@ func BenchmarkDecodeMapIntMapStringStruct3(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v map[int]map[string]bench.Struct3
if err := d.Decode(in, &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode(in, &v, jscandec.DefaultOptions); err != nil {
b.Fatal(err)
}
}
Expand Down
4 changes: 2 additions & 2 deletions bench/map_string_string_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func TestImplementationsMapStringString(t *testing.T) {
)
require.NoError(t, err)
var v map[string]string
if err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err != nil {
t.Fatal(err)
}
require.Equal(t, expect(), v)
Expand Down Expand Up @@ -167,7 +167,7 @@ func BenchmarkDecodeMapStringString(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v map[string]string
if err := d.Decode(in, &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode(in, &v, jscandec.DefaultOptions); err != nil {
b.Fatal(err)
}
}
Expand Down
4 changes: 2 additions & 2 deletions bench/struct3_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func TestImplementationsStruct3(t *testing.T) {
}
require.NoError(t, err)
var v bench.Struct3
if err := d.Decode([]byte(in), &v, opts); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, opts); err != nil {
t.Fatal(err)
}
require.Equal(t, expect(), v)
Expand Down Expand Up @@ -192,7 +192,7 @@ func BenchmarkDecodeStruct3(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v bench.Struct3
if err := d.Decode(in, &v, opts); err.IsErr() {
if _, err := d.Decode(in, &v, opts); err != nil {
b.Fatal(err)
}
}
Expand Down
4 changes: 2 additions & 2 deletions bench/struct_vector3d_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func TestImplementationsStructVector3D(t *testing.T) {
)
require.NoError(t, err)
var v bench.StructVector3D
if err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode([]byte(in), &v, jscandec.DefaultOptions); err != nil {
t.Fatal(err)
}
require.Equal(t, expect(), v)
Expand Down Expand Up @@ -171,7 +171,7 @@ func BenchmarkDecodeStructVector3D(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
var v bench.StructVector3D
if err := d.Decode(in, &v, jscandec.DefaultOptions); err.IsErr() {
if _, err := d.Decode(in, &v, jscandec.DefaultOptions); err != nil {
b.Fatal(err)
}
}
Expand Down
Loading

0 comments on commit dd5e400

Please sign in to comment.