Error instead of panic when deserializing non-identifier field name #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.84% // Head: 91.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 88.84% 91.25% +2.41%
==========================================
Files 55 56 +1
Lines 6437 6542 +105
==========================================
+ Hits 5719 5970 +251
+ Misses 718 572 -146
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
juntyr
added a commit
to juntyr/ron
that referenced
this pull request
Aug 15, 2023
…on-rs#415) * Error instead of panic when deserializing non-identifier field name * Fix code coverage for tests * Added CHANGELOG entry
juntyr
added a commit
to juntyr/ron
that referenced
this pull request
Aug 16, 2023
…on-rs#415) * Error instead of panic when deserializing non-identifier field name * Fix code coverage for tests * Added CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while but the
unimplemented!()panic could in theory have been triggered from user code. Now, deserialising a field name with a type that requests a non-identifier from serde will produce an error instead of panicking.CHANGELOG.md