review2_part2

- add assertions about input patameter maxIter and numInit
- package check

R/clustering_functions.R

@@ -175,8 +175,8 @@ setMethod("pkbc", signature(dat = "ANY"),
           stop("nClust must be a single value or a numeric vector of possible
                   values")
        }
-       if(is.vector(maxIter) & is.integer(maxIter)) {
-          if (maxIter < 0) {
+       if(is.vector(maxIter) & is.numeric(maxIter)) {
+          if (maxIter < 1) {
              stop("Input parameter maxIter must be an integer greater than 0.")
           }
        } else {
@@ -190,8 +190,8 @@ setMethod("pkbc", signature(dat = "ANY"),
           stop(paste("Unrecognized value ", initMethod, " in input 
           parameter initMethod.", sep=''))
        }
-       if(is.vector(numInit) & is.integer(numInit)) {
-          if (numInit < 0) {
+       if(is.vector(numInit) & is.numeric(numInit)) {
+          if (numInit < 1) {
              stop("Input parameter numInit must be greater than 0.")
           }
        } else {
@@ -567,7 +567,6 @@ setGeneric("stats_clusters",function(object,...) {
 #'
 #'
 #' @srrstats {G1.4} roxigen2 is used
-#' @srrstats {UL3.2} true label can be provided as a separate input
 #' @srrstats {UL3.4} the function computes summary statistics with respect to 
 #'                   the identified clusters.
 #'                   
@@ -660,7 +659,7 @@ setMethod("stats_clusters", "pkbc", function(object, k) {
 #' component analysis for functional data." Test 8, 1–73. 
 #' https://doi.org/10.1007/BF02595862
 #' 
-#' 
+#' @srrstats {UL3.2} true label can be provided as a separate input
 #' @srrstats {UL6.1} this function includes a plot method
 #' @srrstats {UL6.0,UL6.2} plot method for pkbc object
 #' 

tests/testthat/test-pkbc.R

@@ -25,12 +25,12 @@ test_that("Error is thrown for invalid inputs", {
    "Input parameter nClust is required. Provide one specific 
                value or a set of possible values.", fixed=TRUE)
    expect_error(pkbc(dat, nClust="invalid"), 
-                "nClust must be a signle value or a numeric vector of possible
+                "nClust must be a single value or a numeric vector of possible
                   values", fixed=TRUE)
 
    #Invalid maxIter
    expect_error(pkbc(dat, nClust=2,maxIter=0), 
-                "Input parameter maxIter must be greater than 0")
+                "Input parameter maxIter must be an integer greater than 0.")
 
    #Invalid initMethod
    expect_error(pkbc(dat, nClust=2,initMethod="Invalid"), 
@@ -39,7 +39,7 @@ test_that("Error is thrown for invalid inputs", {
 
    #Invalid numInit
    expect_error(pkbc(dat, nClust=2,numInit=0), 
-                "Input parameter numInit must be greater than 0")
+                "Input parameter numInit must be greater than 0.")
 })
 
 # Test 2: Verify Error on Invalid data

vignettes/Introduction.R

@@ -15,7 +15,7 @@ library(QuadratiK)
 ## -----------------------------------------------------------------------------
 x <- matrix(rnorm(100), ncol = 2)
 # Does x come from a multivariate standard normal distribution?
-kb.test(x, h=0.4)
+kb.test(x, h = 0.4)
 
 ## -----------------------------------------------------------------------------
 x <- matrix(rnorm(100,4), ncol = 2)