Add support for NV12 encoding in cv_bridge #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update getCvType to return CV_8UC1 for NV12 encoding. - Extend Encoding enum to include NV12. - Enhance getEncoding to recognize NV12. - Add conversion codes for NV12 to GRAY, RGB, BGR, RGBA, and BGRA. - Modify conversion logic to handle NV12 as a color format. - Adjust matFromImage to account for height scaling in NV12 images. Signed-off-by: Zhaoyuan Cheng <[email protected]>
- Corrected the error message to include height scaling in the size calculation. - Adjusted the formatting for better readability. Signed-off-by: Zhaoyuan Cheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the NV12 encoding in the
cv_bridgepackage. Change depends on common_interfaces PR: ros2/common_interfaces#264The following changes have been made:
getCvTypeandgetEncodingfunctions to handle NV12 encoding.matFromImageto correctly handle height scaling for NV12 encoding.Changes
Encoding Support:
NV12to theEncodingenum.getCvTypeandgetEncodingfunctions to recognizeNV12.Conversion Codes:
NV12toGRAY,RGB,BGR,RGBA, andBGRAingetConversionCodes.Height Scaling:
matFromImageto account for height scaling when the encoding isNV12.