Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python3 port of ntp_monitor.py #233

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Fix python3 port of ntp_monitor.py #233

merged 1 commit into from
Jul 12, 2022

Conversation

chrisflesher
Copy link

@chrisflesher chrisflesher commented Jul 11, 2022 •
edited
Loading

Some fields should be strings instead of bytes

@chrisflesher chrisflesher changed the title Diagnostic error meesage requires a string instead of bytes Fix type error Jul 11, 2022
@chrisflesher chrisflesher changed the title Fix type error Fix ntp_monitor.py type error Jul 11, 2022
@chrisflesher chrisflesher changed the title Fix ntp_monitor.py type error Fix python3 port of ntp_monitor.py Jul 11, 2022
g-gemignani
g-gemignani approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@g-gemignani g-gemignani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

g-gemignani
g-gemignani approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@g-gemignani g-gemignani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@g-gemignani g-gemignani merged commit dbc73ff into ros:noetic-devel Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-gemignani g-gemignani g-gemignani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisflesher @g-gemignani