Fail creation of entities if qos contains unknown settings #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Mar 4, 2025
Timple
reviewed
Mar 4, 2025
| ///============================================================================= | ||
| bool QoS::is_supported(const rmw_qos_profile_t & qos_profile) | ||
| { | ||
| if (qos_profile.history == RMW_QOS_POLICY_HISTORY_UNKNOWN || |
There was a problem hiding this comment.
bool QoS::is_supported(const rmw_qos_profile_t & qos_profile)
{
return (qos_profile.history != RMW_QOS_POLICY_HISTORY_UNKNOWN &&
qos_profile.reliability != RMW_QOS_POLICY_RELIABILITY_UNKNOWN &&
qos_profile.durability != RMW_QOS_POLICY_DURABILITY_UNKNOWN &&
qos_profile.liveliness != RMW_QOS_POLICY_LIVELINESS_UNKNOWN)
}This is a strange way of inverting a condition:
if (condition)
{
return false;
}
return true;There was a problem hiding this comment.
I don't know if there is an objective "right way" here. I could argue that the current implementation is more readable or that I could add a debug log statement inside the braces 🤷🏼♂️
It's probably worth spending our efforts on outstanding items like #493, #391 to get rmw_zenoh ready for kilted instead :)
There was a problem hiding this comment.
I don't mind much though. I just triggered on the logic flip 😃
…pported Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/handle_unknown_qos
branch
from
640c741 to
f812b59
Compare
|
I made this release to fix CI ros/rosdistro#44667 |
ahcorde
approved these changes
Mar 5, 2025
|
From source is compiling properly, merging |
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Signed-off-by: Yadunund <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 1fbdc74)
ahcorde
pushed a commit
that referenced
this pull request
Mar 5, 2025
Signed-off-by: Yadunund <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 1fbdc74) Co-authored-by: yadunund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses some of the failing tests in #481, Specifically those that expect creation of pub/sub/client/service to fail if the qos profile has unknown settings. The changes here make test_service__rmw_zenoh_cpp pass.
This works because QoS::get().best_available_qos() is invoked within all make() functions of these entities which will now return nullptr if qos_profile contains unknown settings.