Added rmw_event_type_is_supported #502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde
changed the title
Yadunund
requested changes
Mar 7, 2025
Co-authored-by: yadunund <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Yadunund
requested changes
Mar 7, 2025
rmw_zenoh_cpp/src/detail/event.hpp
Outdated
| @@ -53,6 +53,8 @@ enum rmw_zenoh_event_type_t | |||
|
|
|||
| rmw_zenoh_event_type_t zenoh_event_from_rmw_event(rmw_event_type_t rmw_event_type); | |||
|
|
|||
| bool event_check_compatible(rmw_event_type_t rmw_event_type); | |||
There was a problem hiding this comment.
If we're keeping this function, we should update rmw_event.cpp to rely on it. Else we can remove this.
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Yadunund
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this issue ros2/rmw#394. Check if a event is supported by the
rmw