-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: tune some values for ROS 2 use cases #509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with usual CI passing.
@Mergifyio backport jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
…er of Nodes (>200) (#509) Co-authored-by: Julien Enoch <[email protected]> Co-authored-by: Yadunund <[email protected]> (cherry picked from commit bab4c93)
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
…er of Nodes (>200) (#509) Co-authored-by: Julien Enoch <[email protected]> Co-authored-by: Yadunund <[email protected]> (cherry picked from commit bab4c93)
Yadunund
pushed a commit
that referenced
this pull request
Mar 7, 2025
…er of Nodes (>200) (#509) (#515) Co-authored-by: Julien Enoch <[email protected]> Co-authored-by: Yadunund <[email protected]> (cherry picked from commit bab4c93) Co-authored-by: Luca Cominardi <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Mar 7, 2025
…er of Nodes (>200) (#509) (#516) Co-authored-by: Julien Enoch <[email protected]> Co-authored-by: Yadunund <[email protected]> (cherry picked from commit bab4c93) Co-authored-by: Luca Cominardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROS 2 systems can experience a large number of nodes (e.g. >200) starting all together.
This may lead to having a large number of connections be initialised at the same time during the startup phase.
This PR updates some Zenoh default limits that are deemed too small for the ROS 2 cases for both the Router and the Nodes. The reason for each update is documented directly in the config files.
No behaviour change is expected to be introduced by this PR, just a smoother out-of-the-box experience for large use cases.