Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some qos test related with Zenoh #551

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Fixed some qos test related with Zenoh #551

merged 4 commits into from
Dec 26, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 4, 2024

No description provided.

@ahcorde
Fixed some qos test related with Zenoh
5411121 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from Yadunund October 4, 2024 10:50
@ahcorde ahcorde self-assigned this Oct 4, 2024
@ahcorde ahcorde requested a review from methylDragon as a code owner October 4, 2024 10:50
@ahcorde ahcorde mentioned this pull request Oct 4, 2024
Closed
@ahcorde ahcorde marked this pull request as draft October 9, 2024 21:14
@ahcorde ahcorde mentioned this pull request Dec 12, 2024
Closed
@ahcorde ahcorde marked this pull request as ready for review December 12, 2024 12:23
@ahcorde ahcorde requested a review from clalancette December 19, 2024 15:10
@ahcorde
Copy link
Contributor Author

ahcorde commented Dec 19, 2024 •
edited
Loading

Pulls: #551
Gist: https://gist.githubusercontent.com/ahcorde/f7e54caa3418f8c164ee31c7803a3fe3/raw/aaef48c19c71a2914b50c4649c17d1d90c5e12e3/ros2.repos
BUILD args: --packages-up-to test_quality_of_service --packages-above-and-dependencies test_quality_of_service
TEST args: --packages-select test_quality_of_service --packages-above test_quality_of_service
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14985

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya reviewed Dec 19, 2024
View reviewed changes
test_quality_of_service/test/test_deadline.cpp Outdated
ASSERT_EQ(1, event.total_count_change);
last_sub_count = event.total_count;
};
if (rmw_implementation_str != "rmw_zenoh_cpp") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually should be okay for now? it prints just warnings.

ros2/rclcpp#2648

@ahcorde
feedback
2922372 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
skip tests
85376e9 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Contributor Author

ahcorde commented Dec 20, 2024

Pulls: #551
Gist: https://gist.githubusercontent.com/ahcorde/cce7870206e78cfedd9c2386a5fc6f3f/raw/aaef48c19c71a2914b50c4649c17d1d90c5e12e3/ros2.repos
BUILD args: --packages-up-to test_quality_of_service --packages-above-and-dependencies test_quality_of_service
TEST args: --packages-select test_quality_of_service --packages-above test_quality_of_service
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14988

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

clalancette
clalancette reviewed Dec 24, 2024
View reviewed changes
test_quality_of_service/include/test_quality_of_service/qos_utilities.hpp Outdated
Comment on lines 93 to 94
const std::string this_rmw_implementation{RCUTILS_STRINGIFY(RMW_IMPLEMENTATION)};
std::string rmw_implementation_str;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm just noticing this. What's the difference between this_rmw_implementation and rmw_implementation_str?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 4d873ee

fujitatomoya
fujitatomoya approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahcorde
Feedback
4d873ee 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Contributor Author

ahcorde commented Dec 26, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde requested a review from clalancette December 26, 2024 21:39
@ahcorde ahcorde merged commit f09a98a into rolling Dec 26, 2024
3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/fix_qos_zeno branch December 26, 2024 21:39
This was referenced Dec 27, 2024
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Awaiting requested review from Yadunund

@methylDragon methylDragon Awaiting requested review from methylDragon

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @clalancette @fujitatomoya