Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

ListenerGroup.shutdown() never called #233

Closed
stratomda opened this issue Feb 27, 2017 · 3 comments
Closed

ListenerGroup.shutdown() never called #233

stratomda opened this issue Feb 27, 2017 · 3 comments
Labels

Comments

@stratomda
Copy link
Contributor

The ListenerGroup.shutdown() method is never called when cleaning up the DefaultNode class. I believe that this is causing a memory leak issue with android_core when trying to shutdown objects that extend NodeMain. See: http://answers.ros.org/question/255722/rosjava-listenergroup-causes-android-memory-leak/

@adamantivm adamantivm added the bug label Mar 1, 2017
@adamantivm
Copy link
Contributor

Thanks for the report @stratomda . I'll try to dig into it when I can get a chance. If you get to it before I do, by all means please submit a PR.

Meanwhile, I'll leave the link to your test code here.

@stratomda
Copy link
Contributor Author

@adamantivm I think I have a fix for this. I have started testing it and should be done in the next few days. This same issue might also be present in android_core under the NodeMainExecutorService class. I will investigate that as well. Wanted to make sure we both aren't working on the same thing.

@adamantivm
Copy link
Contributor

@stratomda thanks very much for the work and for the heads-up. I haven't been able to carve out time to look into this so your pro-activity is appreciated. I'll check here before starting if I don't hear anything else by the time I do get time (not real soon).

stratomda added a commit to stratomda/rosjava_core that referenced this issue Mar 3, 2017
…ecutor ListenerGroup to prevent leak in android when activities are destroyed. Added ability to remove listener from ListenerGroup to fix android_core issue rosjava#254.
adamantivm added a commit that referenced this issue Mar 6, 2017
This closes #233. Adds fix for shutting down Defa…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants