rhel-10.0: Override releasever_{major,minor} with system-release provides #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream commit: 0e283fb This allows setting a releasever_major or releasever_minor independent of releasever, which is needed by EPEL. Related: https://issues.redhat.com/browse/RHEL-68034
Upstream commit: 75e3ff0 The releasever_major and releasever_minor substitution variables are usually derived by splitting releasever on the first `.`. However, to support EPEL 10 [1], we would like a way for distributions to override these values. Specifically, we would like RHEL 10 to have a releasever of `10` with a releasever_major of `10` and a releasever_minor of `0` (later incrementing to `1`, `2`, to correspond with the RHEL minor version). This commit adds a new API function, `detect_releasevers`, which derives releasever, releasever_major, and releasever_minor from virtual provides on the system-release package (any of `DISTROVERPKG`). The detection of releasever is unchanged. releasever_major and releasever_minor are specified by the versions of the `system-release-major` and `system-release-minor` provides, respectively. If the user specifies a `--releasever=X.Y` on the command line, the distribution settings for releasever, releasever_major, and releasever_minor will all be overridden: releasever will be set to X.Y, releasever_major will be set to X, and releasever_minor will be set to Y, same as before. If a user wants to specify a custom releasever_major and releasever_minor, they have to set all three with `--setopt=releasever=X --setopt=releasever_major=Y --setopt=releasever_minor=z`, taking care to put `releasever_major` and `releasever_minor` after `releasever` so they are not overridden. [1] https://issues.redhat.com/browse/RHEL-68034
Upstream commit: 017bbab Allows the user to override the $releasever_major and $releasever_minor variables on the command line, like --releasever.
Upstream commit: 593ab0c Adds dnf.rpm.detect_releasevers to the API docs and mention it is now preferred over dnf.rpm.detect_releasever. Updates examples/install_extension.py to use detect_releasevers and set the releasever_major and releasever_minor substitution variables.
Upstream commit: ba5ddbd
carlwgeorge
changed the title
Conan-Kudo
approved these changes
Feb 27, 2025
evan-goode
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
https://issues.redhat.com/browse/RHEL-76498 has been approved as an exception. Thanks! Merging.
evan-goode
merged commit 33426fa
into
rpm-software-management:rhel-10.0
2 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2198 to RHEL 10. This patchset requires rpm-software-management/libdnf#1697.
Resolves: https://issues.redhat.com/browse/RHEL-68034