TransactionProgress::scriptout improvements and documentation #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scriptout hook receives a lot of gratuitous calls when there is no scriptlet output, leading to it being called with a None value. This is pointless and confusing to consumers, so skip calling the hook if `_scriptOutput()` returns None. Signed-off-by: Chris Riches <[email protected]>
This function was undocumented, but appears intended to be public and is very important to anyone wanting to report on all transaction activities. Signed-off-by: Chris Riches <[email protected]>
pkratoch
merged commit aaa235d
into
rpm-software-management:master
3 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook should really be documented, and fix a quirk in its behaviour while we're here.