Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionProgress::scriptout improvements and documentation #2216

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

cjriches
Copy link
Contributor

@cjriches cjriches commented Mar 6, 2025

This hook should really be documented, and fix a quirk in its behaviour while we're here.

cjriches added 2 commits March 6, 2025 13:48
The scriptout hook receives a lot of gratuitous calls when there is no
scriptlet output, leading to it being called with a None value. This is
pointless and confusing to consumers, so skip calling the hook if
`_scriptOutput()` returns None.

Signed-off-by: Chris Riches <[email protected]>
This function was undocumented, but appears intended to be public and is
very important to anyone wanting to report on all transaction
activities.

Signed-off-by: Chris Riches <[email protected]>
@cjriches cjriches requested a review from a team as a code owner March 6, 2025 14:02
@cjriches cjriches requested review from pkratoch and removed request for a team March 6, 2025 14:02
@pkratoch pkratoch merged commit aaa235d into rpm-software-management:master Mar 12, 2025
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants