Discourage controller specs in README #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlue
changed the title
xaviershay
previously requested changes
Jul 7, 2017
| end | ||
| ``` | ||
|
|
||
| For more information, see [cucumber scenarios for controller |
There was a problem hiding this comment.
Should probably keep this link around
There was a problem hiding this comment.
Oops, accidentally closed previous review.
Link restored!
fables-tales
approved these changes
Aug 26, 2017
|
LGTM. @xaviershay your feedback has been addressed so I'm going to merge. |
fables-tales
dismissed
xaviershay’s stale review
author has addressed feedback from this review.
|
thanks, sorry I missed the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #1838.