-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add app$waitForValue
#304
add app$waitForValue
#304
Conversation
I don't know if this would actually work.... app <- ShinyDriver$new("../../", seed = 100, shinyOptions = list(display.mode = "normal"))
shinyOptions = list(display.mode = "normal"))
app$snapshotInit("mytest")
initValue <- app$waitForValue("state")
app$snapshot()
app$setInputs(state = "California")
app$waitForValue("state", initValue)
app$snapshot() I have a feeling that the last snapshot will be called before the ggplot2 value is set. I think it would almost need a app$setInputs(state = "California")
app$waitForValue("state", initValue)
app$waitForValue("plot", priorPlotValue, iotype = "output")
app$snapshot() @wch What about adding another function that says |
* Use timeoutSec * Use value to check if error * Pass in self/private as `app` doesn't exist * Make sure errors are silent * Give more options for iotype at function def and match the arg
Thoughts:
priorPlotValue <- app$getValue("plot")
app$setInputs(state = "California")
app$waitForValue("state", ignore = list(initValue))
app$waitForValue("plot", ignore = list(priorPlotValue), iotype = "output")
app$snapshot() |
* master: Bump shiny version to >= 1.3.2 and update tests (#305)
…e `app$waitForValue`
Fixes #301
Prior
New
System time for both
waitForValue
calls take < 1s on my machine.