Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements in automatic recovery mode #35

Closed
tailrecur opened this issue Nov 18, 2013 · 2 comments · Fixed by #136
Closed

Logging improvements in automatic recovery mode #35

tailrecur opened this issue Nov 18, 2013 · 2 comments · Fixed by #136

Comments

@tailrecur
Copy link

march_hare version: 2.0.0.rc5

I was manually testing the automatic recovery process with march_hare. When the connection to the server is lost, march_hare does not log any messages to stdout so there is no visible clue that it is attempting recovery.

This caused me to spend sometime toggling different options to get automatic recovery working. After a bit, I realised that when the server came back up, march_hare would automatically reconnect.

It would be nice to see some log messages (similar to what bunny does) stating what march_hare is trying to do.

@michaelklishin
Copy link
Member

There is a bunch of TODO's around logging in the code but it's not as straightforward for March Hare. Parts of the
code are not in Ruby and it's not clear which logger should be used. In fact, in Bunny master we already had to provide support for custom loggers which means there is no consensus.

@michaelklishin michaelklishin changed the title Stdout Logging when in automatic recovery mode Logging improvements in automatic recovery mode Apr 2, 2014
michaelklishin added a commit that referenced this issue Jun 30, 2014
@michaelklishin
Copy link
Member

The need for this was just highlighted in #107. I think we should consider copying what Bunny uses for logging. The only different part is that we can get exceptions that are Java objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants