-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SortedSet implementations #2
Conversation
It required RBTree to perform decently and the external dependency was not suitable for a standard library. The pure ruby fallback implementation was originally meant to be an example of how to write a subclass of Set, and its poor performance was not suitable for use in production. I decided it should be distributed as an external library instead of bundling it with Set.
I completely agree, and it's performance is not great. |
I don't know if these are used much or at all (I notice that there's a typo in the class |
Just pushed sorted_set 1.0.0: https://rubygems.org/gems/sorted_set |
SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
Add sorted_set gem to Gemfile SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
Add sorted_set gem to Gemfile SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
SortedSet is extracted into its own gem in Ruby 3+, as per ruby/set#2.
It required RBTree to perform decently and the external dependency was not suitable for a standard library. The pure ruby fallback implementation was originally meant to be a demonstration of how to write a subclass of Set, and its poor performance was not suitable for use in production.
I decided it should be distributed as an external library instead of bundling it with Set.